Skip to content

Commit 7667c14

Browse files
jaschdocmarcphilipp
authored andcommitted
Fix race condition in NodeTestTask (#5427)
Fixed by making field `parentContext` volatile. Issue: #5408 Signed-off-by: Jakob Villumsen <villumsen@google.com>
1 parent ac01f2d commit 7667c14

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

documentation/modules/ROOT/partials/release-notes/release-notes-5.14.4.adoc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ repository on GitHub.
1313
[[v5.14.4-junit-platform]]
1414
=== JUnit Platform
1515

16-
No changes.
16+
[[v5.14.4-junit-platform-bug-fixes]]
17+
==== Bug Fixes
1718

19+
* A race condition in `NodeTestTask.parentContext` has been fixed.
1820

1921
[[v5.14.4-junit-jupiter]]
2022
=== JUnit Jupiter

junit-platform-engine/src/main/java/org/junit/platform/engine/support/hierarchical/NodeTestTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class NodeTestTask<C extends EngineExecutionContext> implements TestTask {
5151
private final Node<C> node;
5252
private final Runnable finalizer;
5353

54-
private C parentContext;
54+
private volatile C parentContext;
5555
private C context;
5656

5757
private SkipResult skipResult;

0 commit comments

Comments
 (0)