TruffleRuby support#145
Merged
Merged
Conversation
k0kubun
force-pushed
the
truffleruby-support
branch
from
44b60ad to
a345008
Compare
eregon
reviewed
Sep 8, 2019
| assert_equal expected, actual | ||
| end | ||
| end | ||
| end if RUBY_ENGINE != 'truffleruby' # truffleruby cannot run Haml |
There was a problem hiding this comment.
truffleruby cannot run Haml
Is it because of missing Ripper support? (truffleruby/truffleruby#1712)
eregon
reviewed
Sep 8, 2019
| @@ -1,5 +1,6 @@ | |||
| #include <ruby.h> | |||
| #include <ruby/encoding.h> | |||
| #ifndef TRUFFLERUBY | |||
There was a problem hiding this comment.
This seems to skip this entire file under file under TruffleRuby, is it because of missing rb_ary_sort_bang?
Is a pure-Ruby implementation used instead then?
Owner
Author
There was a problem hiding this comment.
Both are correct. truffleruby/truffleruby#1600 was also relevant, but I could workaround it by casting VALUE to ptrdiff_t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close https://github.com/k0kubun/hamlit/issues/144