This repository was archived by the owner on Jun 27, 2024. It is now read-only.
feat(solids): move processing to 'background'#28
Merged
kaosat-dev merged 23 commits intomasterfrom Jan 30, 2018
Merged
Conversation
geometry in a background worker * added sideeffect * modified reducers & actions
…processing * fleshed out setDesignSolids , setting param values etc as well * modified actions sending data to workers * fixed issue with 'busy' state * lots of cleanups
extracted 'select'/choice values * also changed output from worker from params to paramsValue for clarity
* data types of params are now enforced, ensuring correct dropdown behaviour * moved for now to the same controls extraction for instantUpdate * added some hack-ish error handling
* added ability to drop params with no definitions (usefull if param definitions change: ie get added) instead of throwing * renamed enforceParamDefinitions to applyParameterDefinitions * renamed getparamValues to getParameterValues
* now takes in path to worker instead of worker instance * experimenting with worker termination/recreation
new version of createParamControls * this also solves issues with choice/select/dropdowns
when source script changes
on each message (to avoid long running/blocking workers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the heavy processing outside the UI thread, allowing non blocking processing, timeouts etc without crashing the app