Skip to content

Commit 611e31e

Browse files
committed
fix missing configs in package.json for Modular and RLC
1 parent 2752fd3 commit 611e31e

34 files changed

Lines changed: 85 additions & 4 deletions

File tree

packages/rlc-common/src/metadata/packageJson/packageCommon.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,12 @@ function getEsmEntrypointInformation(config: PackageCommonInfoConfig) {
9999
return;
100100
}
101101

102-
return { tshy: getTshyConfig(config), type: "module" };
102+
return {
103+
tshy: getTshyConfig(config),
104+
type: "module",
105+
browser: "./dist/browser/index.js",
106+
"react-native": "./dist/react-native/index.js"
107+
};
103108
}
104109

105110
export function getTshyConfig(config: PackageCommonInfoConfig) {

packages/rlc-common/test/integration/packageJson.spec.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,24 @@ describe("Package file generation", () => {
449449
"echo skipped"
450450
);
451451
});
452+
453+
it("should include browser and react-native in package.json", () => {
454+
const model = createMockModel({
455+
...baseConfig,
456+
azureArm: true,
457+
isModularLibrary: true
458+
});
459+
const packageFileContent = buildPackageFile(model);
460+
const packageFile = JSON.parse(packageFileContent?.content ?? "{}");
461+
462+
expect(packageFile).to.have.property(
463+
"browser", "./dist/browser/index.js",
464+
);
465+
expect(packageFile).to.have.property(
466+
"react-native", "./dist/react-native/index.js"
467+
);
468+
469+
});
452470
});
453471

454472
describe("Azure flavor for standalone library", () => {

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/sdk/test/arm-test/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
"selfLink": false
3030
},
3131
"type": "module",
32+
"browser": "./dist/browser/index.js",
33+
"react-native": "./dist/react-native/index.js",
3234
"keywords": [
3335
"node",
3436
"azure",

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/sdk/test/arm-test/src/api/dataProducts/operations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ import {
4343
PagedAsyncIterableIterator,
4444
buildPagedAsyncIterator,
4545
} from "../../static-helpers/pagingHelpers.js";
46-
import { getLongRunningPoller } from "../../static-helpers/pollingHelpers.js";
4746
import { expandUrlTemplate } from "../../static-helpers/urlTemplate.js";
47+
import { getLongRunningPoller } from "../../static-helpers/pollingHelpers.js";
4848
import {
4949
StreamableMethod,
5050
PathUncheckedResponse,

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/sdk/test/arm-test/src/api/dataTypes/operations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ import {
3030
PagedAsyncIterableIterator,
3131
buildPagedAsyncIterator,
3232
} from "../../static-helpers/pagingHelpers.js";
33-
import { getLongRunningPoller } from "../../static-helpers/pollingHelpers.js";
3433
import { expandUrlTemplate } from "../../static-helpers/urlTemplate.js";
34+
import { getLongRunningPoller } from "../../static-helpers/pollingHelpers.js";
3535
import {
3636
StreamableMethod,
3737
PathUncheckedResponse,

packages/typespec-test/test/ai/generated/typespec-ts/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
"selfLink": false
3131
},
3232
"type": "module",
33+
"browser": "./dist/browser/index.js",
34+
"react-native": "./dist/react-native/index.js",
3335
"keywords": [
3436
"node",
3537
"azure",

packages/typespec-test/test/anomalyDetector/generated/typespec-ts/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
"selfLink": false
3030
},
3131
"type": "module",
32+
"browser": "./dist/browser/index.js",
33+
"react-native": "./dist/react-native/index.js",
3234
"keywords": [
3335
"node",
3436
"azure",

packages/typespec-test/test/anomalyDetector/generated/typespec-ts/src/api/multivariate/operations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ import {
2828
MultivariateTrainMultivariateModelOptionalParams,
2929
MultivariateGetMultivariateBatchDetectionResultOptionalParams,
3030
} from "./options.js";
31+
import { expandUrlTemplate } from "../../static-helpers/urlTemplate.js";
3132
import {
3233
PagedAsyncIterableIterator,
3334
buildPagedAsyncIterator,
3435
} from "../../static-helpers/pagingHelpers.js";
35-
import { expandUrlTemplate } from "../../static-helpers/urlTemplate.js";
3636
import {
3737
StreamableMethod,
3838
PathUncheckedResponse,

packages/typespec-test/test/authoring/generated/typespec-ts/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
"selfLink": false
2424
},
2525
"type": "module",
26+
"browser": "./dist/browser/index.js",
27+
"react-native": "./dist/react-native/index.js",
2628
"keywords": [
2729
"node",
2830
"azure",

packages/typespec-test/test/batch_modular/generated/typespec-ts/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
"selfLink": false
2626
},
2727
"type": "module",
28+
"browser": "./dist/browser/index.js",
29+
"react-native": "./dist/react-native/index.js",
2830
"keywords": [
2931
"node",
3032
"azure",

0 commit comments

Comments
 (0)