fix(deps): update dependency @google-cloud/common to ^0.27.0 (googleapis#525)

Author: renovate[bot]

package.json

@@ -53,7 +53,7 @@
     ]
   },
   "dependencies": {
-    "@google-cloud/common": "^0.26.0",
+    "@google-cloud/common": "^0.27.0",
     "@google-cloud/paginator": "^0.1.0",
     "@google-cloud/promisify": "^0.3.0",
     "arrify": "^1.0.0",

src/bucket.ts

@@ -381,7 +381,7 @@ export type GetBucketResponse = [Bucket, request.Response];
  * @param {Bucket} bucket The {@link Bucket}.
  * @param {object} apiResponse The full API response.
  */
-export interface GetBucketCallback extends InstanceResponseCallback {
+export interface GetBucketCallback {
   (err: ApiError|null, bucket: Bucket|null,
    apiResponse: request.Response): void;
 }

src/file.ts

@@ -875,7 +875,7 @@ class File extends ServiceObject {
     options = extend(true, {}, options);
     callback = callback || util.noop;
 
-    let destBucket: Bucket|File;
+    let destBucket: Bucket;
     let destName: string;
     let newFile: File;
 
@@ -888,8 +888,7 @@ class File extends ServiceObject {
         destBucket = this.bucket;
         destName = destination;
       }
-    } else if (
-        destination.constructor && destination.constructor.name === 'Bucket') {
+    } else if (destination instanceof Bucket) {
       destBucket = destination;
       destName = this.name;
     } else if (destination instanceof File) {

system-test/.eslintrc.yml

@@ -407,7 +407,8 @@ describe('storage', () => {
       });
 
       it('should not expose default api', () => {
-        assert.strictEqual(typeof file.default, 'undefined');
+        // tslint:disable-next-line no-any
+        assert.strictEqual(typeof (file as any).default, 'undefined');
       });
 
       it('should grant an account access', done => {
@@ -2379,9 +2380,9 @@ describe('storage', () => {
                     location: 'ASIA-EAST1',
                     dra: true,
                   },
-                  cb as InstanceResponseCallback);
+                  cb);
             },
-            cb => file.copy(copiedFile, cb as InstanceResponseCallback)
+            cb => file.copy(copiedFile, cb as CopyCallback)
           ],
           err => {
             assert.ifError(err);

system-test/storage.ts

@@ -26,25 +26,27 @@ const snakeize = require('snakeize');
 import * as stream from 'stream';
 import * as through from 'through2';
 import {Bucket, Channel, Notification} from '../src';
-import {CreateWriteStreamOptions, File, SetFileMetadataOptions} from '../src/file';
+import {CreateWriteStreamOptions, File, SetFileMetadataOptions, FileOptions} from '../src/file';
 import {PromisifyAllOptions} from '@google-cloud/promisify';
 import * as r from 'request';
 import {GetBucketMetadataCallback, GetFilesOptions, MakeAllFilesPublicPrivateOptions, SetBucketMetadataCallback} from '../src/bucket';
 import {AddAclOptions} from '../src/acl';
 
+
+
 class FakeFile {
   calledWith_: IArguments;
   bucket: Bucket;
   name: string;
-  options?: {};
+  options: FileOptions;
   metadata: {};
   createWriteStream: Function;
-  isSameFile?: () => boolean;
-  constructor(bucket: Bucket, name: string, options?: {}) {
+  isSameFile = () => false;
+  constructor(bucket: Bucket, name: string, options?: FileOptions) {
     this.calledWith_ = arguments;
     this.bucket = bucket;
     this.name = name;
-    this.options = options;
+    this.options = options || {};
     this.metadata = {};
 
     this.createWriteStream = (options: CreateWriteStreamOptions) => {
@@ -1226,7 +1228,7 @@ describe('Bucket', () => {
 
   describe('file', () => {
     const FILE_NAME = 'remote-file-name.jpg';
-    let file: File;
+    let file: FakeFile;
     const options = {a: 'b', c: 'd'};
 
     beforeEach(() => {
@@ -2242,7 +2244,7 @@ describe('Bucket', () => {
         encryptionKey: 'key',
         kmsKeyName: 'kms-key-name',
       };
-      bucket.upload(filepath, options, (err: Error, file: File) => {
+      bucket.upload(filepath, options, (err: Error, file: FakeFile) => {
         assert.ifError(err);
         assert.strictEqual(file.bucket.name, bucket.name);
         assert.deepStrictEqual(file.metadata, metadata);
@@ -2259,7 +2261,7 @@ describe('Bucket', () => {
         encryptionKey: 'key',
         kmsKeyName: 'kms-key-name',
       };
-      bucket.upload(filepath, options, (err: Error, file: File) => {
+      bucket.upload(filepath, options, (err: Error, file: FakeFile) => {
         assert.ifError(err);
         assert.strictEqual(file.bucket.name, bucket.name);
         assert.strictEqual(file.name, newFileName);
@@ -2277,7 +2279,7 @@ describe('Bucket', () => {
         encryptionKey: 'key',
         kmsKeyName: 'kms-key-name',
       };
-      bucket.upload(filepath, options, (err: Error, file: File) => {
+      bucket.upload(filepath, options, (err: Error, file: FakeFile) => {
         assert.ifError(err);
         assert.strictEqual(file.bucket.name, bucket.name);
         assert.strictEqual(file.name, newFileName);
@@ -2294,7 +2296,7 @@ describe('Bucket', () => {
         return true;
       };
       const options = {destination: fakeFile};
-      bucket.upload(filepath, options, (err: Error, file: File) => {
+      bucket.upload(filepath, options, (err: Error, file: FakeFile) => {
         assert.ifError(err);
         assert(file.isSameFile());
         done();
@@ -2307,7 +2309,7 @@ describe('Bucket', () => {
         return true;
       };
       const options = {destination: fakeFile, metadata};
-      bucket.upload(filepath, options, (err: Error, file: File) => {
+      bucket.upload(filepath, options, (err: Error, file: FakeFile) => {
         assert.ifError(err);
         assert(file.isSameFile());
         assert.deepStrictEqual(file.metadata, metadata);