Skip to content

Commit 91dde1e

Browse files
kim-emclaude
andcommitted
address review comments
- Rename Aₙ_far → A_not_adjacent, Aₙ_adjacent → A_adjacent (use CoxeterMatrix.A) - Add @[simp] to mul_apply, one_apply, pow_add_one_apply - Add @[to_additive] to normalClosure_singleton_one - Remove ofList section (per eric-wieser's suggestion to use FreeMonoid API instead) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 490e8bc commit 91dde1e

File tree

4 files changed

+10
-39
lines changed

4 files changed

+10
-39
lines changed

Mathlib/Algebra/Group/End.lean

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,15 @@ def equivUnitsEnd : Perm α ≃* Units (Function.End α) where
9898
def _root_.MonoidHom.toHomPerm {G : Type*} [Group G] (f : G →* Function.End α) : G →* Perm α :=
9999
equivUnitsEnd.symm.toMonoidHom.comp f.toHomUnits
100100

101-
@[grind =]
101+
@[simp, grind =]
102102
theorem mul_apply (f g : Perm α) (x) : (f * g) x = f (g x) :=
103103
rfl
104104

105-
@[grind =]
105+
@[simp, grind =]
106106
theorem one_apply (x) : (1 : Perm α) x = x :=
107107
rfl
108108

109-
@[grind =]
109+
@[simp, grind =]
110110
theorem pow_add_one_apply (f : Perm α) (n : ℕ) (x : α) :
111111
(f ^ (n + 1)) x = (f^n) (f x) := by
112112
rfl

Mathlib/Algebra/Group/Subgroup/Basic.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ theorem normalClosure_closure_eq_normalClosure {s : Set G} :
550550
lemma normalClosure_empty : normalClosure (∅ : Set G) = (⊥ : Subgroup G) := by
551551
rw [← normalClosure_closure_eq_normalClosure, closure_empty, normalClosure_eq_self]
552552

553-
@[simp]
553+
@[to_additive (attr := simp)]
554554
theorem normalClosure_singleton_one : normalClosure ({1} : Set G) = ⊥ :=
555555
le_antisymm (normalClosure_le_normal (by simp)) bot_le
556556

Mathlib/GroupTheory/Coxeter/Matrix.lean

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,14 @@ protected def A : CoxeterMatrix (Fin n) where
114114

115115
@[deprecated (since := "2026-03-25")] alias Aₙ := CoxeterMatrix.A
116116

117-
theorem Aₙ_adjacent (n : ℕ) (i j : Fin n) (h : (i : ℕ) + 1 = j ∨ (j : ℕ) + 1 = i) :
118-
(Aₙ n) i j = 3 := by
119-
simp only [Aₙ, Fin.ext_iff, Matrix.of_apply]
117+
theorem A_adjacent (n : ℕ) (i j : Fin n) (h : (i : ℕ) + 1 = j ∨ (j : ℕ) + 1 = i) :
118+
(CoxeterMatrix.A n) i j = 3 := by
119+
simp only [CoxeterMatrix.A, Fin.ext_iff, Matrix.of_apply]
120120
grind
121121

122-
theorem Aₙ_far (n : ℕ) (i j : Fin n) (h1 : i ≠ j) (h2 : (i : ℕ) + 1 ≠ j)
123-
(h3 : (j : ℕ) + 1 ≠ i) : (Aₙ n) i j = 2 := by
124-
simp only [Aₙ, Matrix.of_apply]
122+
theorem A_not_adjacent (n : ℕ) (i j : Fin n) (h1 : i ≠ j) (h2 : (i : ℕ) + 1 ≠ j)
123+
(h3 : (j : ℕ) + 1 ≠ i) : (CoxeterMatrix.A n) i j = 2 := by
124+
simp only [CoxeterMatrix.A, Matrix.of_apply]
125125
grind
126126

127127
/-- The Coxeter matrix of type Bₙ.

Mathlib/GroupTheory/FreeGroup/Basic.lean

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -908,35 +908,6 @@ theorem sum.map_inv : sum x⁻¹ = -sum x :=
908908

909909
end Sum
910910

911-
section OfList
912-
913-
variable {α : Type*}
914-
915-
/-- Convert a list of generators to an element of the free group by taking the product of `of`
916-
applied to each element. -/
917-
@[to_additive /-- Convert a list of generators to an element of the additive free group by taking
918-
the sum of `of` applied to each element. -/]
919-
def ofList (l : List α) : FreeGroup α := (l.map of).prod
920-
921-
@[to_additive (attr := simp)]
922-
theorem ofList_nil : ofList ([] : List α) = 1 := rfl
923-
924-
@[to_additive (attr := simp)]
925-
theorem ofList_singleton (x : α) : ofList [x] = of x := by simp [ofList]
926-
927-
@[to_additive]
928-
theorem ofList_cons (x : α) (l : List α) : ofList (x :: l) = of x * ofList l := by simp [ofList]
929-
930-
@[to_additive]
931-
theorem ofList_concat (l : List α) (x : α) : ofList (l.concat x) = ofList l * of x := by
932-
simp [ofList]
933-
934-
@[to_additive]
935-
theorem ofList_append (l₁ l₂ : List α) : ofList (l₁ ++ l₂) = ofList l₁ * ofList l₂ := by
936-
simp [ofList]
937-
938-
end OfList
939-
940911
/-- The bijection between the free group on the empty type, and a type with one element. -/
941912
@[to_additive
942913
(attr := deprecated "Use `Equiv.ofUnique (FreeGroup Empty) Unit` instead,

0 commit comments

Comments
 (0)