Skip to content

Commit 2c5c754

Browse files
authored
Merge branch 'main' into patch-48
2 parents 37cf3ad + fb1a814 commit 2c5c754

File tree

1,525 files changed

+21180
-23088
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,525 files changed

+21180
-23088
lines changed

.github/dependabot.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ updates:
99
directory: "/"
1010
schedule:
1111
interval: "daily"
12+
versioning-strategy: increase-if-necessary

.github/workflows/deploy-preview.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
owner: context.repo.owner,
8181
repo: context.repo.repo,
8282
issue_number: pullRequestNumber,
83-
body: `${start} **[Your pull request preview is ready](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466)**\n\nPlease use this preview to check your changes. Ideally use [the **test documentation** template](https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L38-L69) and document your test results by commenting on the PR. This will speed up the review process for everyone.\n\nFYI, once this PR is merged, you can use [the iD Editor Preview](http://preview.ideditor.com/) to test your changes in interaction with all other changes.`
83+
body: `${start} **[Your pull request preview is ready](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.00/48.841708/2.587656)**\n\nPlease use this preview to check your changes. Ideally use [the **test documentation** template](https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L38-L69) and document your test results by commenting on the PR. This will speed up the review process for everyone.\n\nFYI, once this PR is merged, you can use [the iD Editor Preview](http://preview.ideditor.com/) to test your changes in interaction with all other changes.`
8484
});
8585
} else {
8686
console.log(`Preview URL comment already added to PR #${pullRequestNumber}`);

CHANGELOG.md

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,72 @@ _Breaking developer changes, which may affect downstream projects or sites that
2323
[@xxxx]: https://github.com/xxxx
2424
-->
2525

26+
# 6.13.3
27+
##### 2025-Oct-30
28+
29+
* Introduce placeholder presets for still upstream-referenced presets
30+
31+
32+
# 6.13.1
33+
##### 2025-Oct-23
34+
35+
#### New Presets
36+
* Create unsearchable preset for associatedStreet (#997, thanks @serhii-muchychka)
37+
* Preset: shop=mobile\_phone\_accessories (#1406, thanks @UKChris-osm)
38+
* Add Fish Farm / Hatchery preset and `aquaculture=*` field (#1517, thanks @arch0345)
39+
* Add Ceremonial Gate and related presets (#1693, thanks @novolife)
40+
* Add preset for `device_charging_station` (#1611, thanks @paulklie)
41+
#### New and Changed Fields
42+
* Add "Cabins" field to Camp Site preset (#1683, thanks @kjonosm)
43+
* added wood provided field (#1738, thanks @paulklie)
44+
* Update roof shape field to add missing wiki suggestions (#1654, thanks @Shrinks99)
45+
* Add option `container` to `building`field (#1524, thanks @tordans)
46+
* Add `self_checkout` field to shop=supermarket (#1649, thanks @Dimitar5555)
47+
* Add translatable strings to playground field (#1004, thanks @kjonosm)
48+
* Support education tag per approved proposal (#1472, thanks @quincylvania)
49+
* Add strings for `house=` field and disable Taginfo suggestions (#1412, thanks @Dimitar5555)
50+
* Add `groundwater` option to `water_source` field (#1561, thanks @chaos-baum)
51+
* Reference payment\_multi to 'payment:\*' for correct wiki link (#1701, thanks @srujanaelicherla)
52+
#### Changed Presets
53+
* use temaki-paifang icon for Paifang preset (#1767, thanks @novolife)
54+
* add access and fee field to observation tower (#1726, thanks @paulklie)
55+
* Restore optional fields of Bakery preset (#1554, thanks @novolife)
56+
* Standardize `aerialway` preset terms (#1753, thanks @FloEdelmann)
57+
* Add fields to attraction preset (#1713, thanks @srujanaelicherla)
58+
* add terms to shop=water (#1740, thanks @matkoniecz)
59+
* Add toilets related fields to different presets (#1533, thanks @andrewharvey)
60+
* Add term "street fitness" for `leisure=fitness_station` preset (#1660, thanks @Dimitar5555)
61+
* add icon for `tower:construction=dish` (#1716, thanks @k-yle)
62+
* Add icon for fitness station sign preset (#1709, thanks @paulklie)
63+
* Add icon to fitness parallel bars preset (#1710, thanks @paulklie)
64+
* Add icon to push up station preset (#1711, thanks @paulklie)
65+
* Fix missing tag for `memorial=blue_plaque` preset (#1689, thanks @hb0nd)
66+
* Fix icon for Framing Shop preset (#1707, thanks @arch0345)
67+
* Make Kebab Fast Food findable by terms "Doner/Döner" (#1640, thanks @matkoniecz)
68+
* Do not add implicit `sport=disc_golf` to `leisure=disc_golf_course` features (#1639, thanks @Hufkratzer)
69+
* More strictly match historic=building preset (#1677, thanks @tyrasd)
70+
* Remove redundant `internet_access` from preset `aerodrome` (#1676, thanks @tordans)
71+
* Add `inscription` field to `tourism=artwork` (#1664, thanks @kjonosm)
72+
* Add river preset to water category (#1567, thanks @novolife)
73+
* Improve reference for Amphitheater preset (#1647, thanks @arch0345)
74+
#### Regional Presets and Fields
75+
* Restrict Sand Bath field to Japan (#1754, thanks @novolife)
76+
* added wood provided field (#1738, thanks @paulklie)
77+
* Change the default placeholder for `phone` numbers to a country code that no other country uses. (#1491, thanks @youssefelzedy)
78+
* Add charging point terms to charging station (#1698, thanks @FloEdelmann)
79+
#### Bug Fixes
80+
* Fix missing tag for `memorial=blue_plaque` preset (#1689, thanks @hb0nd)
81+
* Do not add implicit `sport=disc_golf` to `leisure=disc_golf_course` features (#1639, thanks @Hufkratzer)
82+
#### Documentation and Other Changes
83+
* CI: Configure dependabot to update package.json (#1255, thanks @tordans)
84+
* Docs: Update wording "Data item", "OSM Wiki data item" (#1506, thanks @tordans)
85+
* Standardize field terms (#1760, thanks @FloEdelmann)
86+
* Cleanup presets and fields to adhere to stricter schema (#1759, thanks @FloEdelmann)
87+
* Standardize preset terms (#1758, thanks @FloEdelmann)
88+
#### Dependencies
89+
* Bump netlify-cli from 22.3.0 to 23.9.3 (#1771, thanks @[dependabot[bot]](https://github.com/apps/dependabot))
90+
91+
2692

2793
# 6.12.0
2894
##### 2025-Jul-23

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ Icons from different sources (_icon sets_) can be used in the tagging schema. He
5050

5151
### Info-`i`
5252

53-
![Screenshot of a preset in iD with the information details open.](https://github.com/openstreetmap/id-tagging-schema/assets/111561/13549318-cd7c-4dd1-9948-7a2d84662f04)
53+
<img alt="Screenshot of a preset in iD with the information details open." src="https://github.com/openstreetmap/id-tagging-schema/assets/111561/13549318-cd7c-4dd1-9948-7a2d84662f04" width="400" />
5454

5555
iD and other tools provide users with a way to learn more about the main tag of a preset. It is important to provide good information in this information panel. Here are a few notes on how to do this:
56-
- Does your tag have a Wikibase entry? Click the small pencil icon next to the text to open the Wikibase item on the OSM wiki. Improve this wording if needed. If the Wikibase item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process).
56+
- Does your tag have a OSM Wiki data item? Click the small pencil icon next to the text to open the data item on the OSM Wiki. Improve this wording if needed. If the data item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process).
5757
- Does your tag have a Wiki page with a good image?
5858
- Your preset might need [a `reference` property](https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference) to force the system to use a specific tag for the information section.
5959

GUIDELINES.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ In addition, the deprecated tag must have reasonably high usage to be considered
4949

5050
Deprecation rules work such that the user sees a message with suggestions and can act only when editing the given element. This makes them well-suited for gradual, human-reviewed updates of taggings like crossings. However, they are not suitable for cleaning up incorrect tagging from the database, especially for low-volume changes.
5151

52-
There are, however, alternatives to consider:
52+
There are, however, alternatives to consider:
5353
- Your cleanup task might be eligible for an automated (bot) edit. [Please learn more on the wiki…](https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct)
5454
- If your task is small enough, a few [editing sessions in JOSM](https://wiki.openstreetmap.org/wiki/JOSM) will often do the trick. However, mass-replacing without checking each object is still considered an automated edit, so the [guidelines apply](https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct). Please consult other mappers first.
5555
- A good way to work down a list of tasks is to create [a MapRoulette Challenge](https://maproulette.org/).
@@ -65,7 +65,7 @@ The user interface must be clear, concise, and easy to use, leaving no room for
6565
- Check the search functionality to ensure other presets do not cause confusion.
6666
- Select an icon or start the process to create a new one.
6767
- Define which fields to show (`fields`) and suggest (`moreFields`), considering the order of fields.
68-
- Check the `(i)` documentation and add or update the [OSM Wikibase item](https://wiki.openstreetmap.org/wiki/Data_items) if needed to provide a helpful short text.
68+
- Check the [`(i)` documentation](./CONTRIBUTING.md#info-i) and add or update the OSM Wiki data item if needed to provide a helpful short text.
6969
- Use the PR preview to add test cases with deep links to OSM objects that demonstrate the preset in use.
7070

7171
## 3. Implement
@@ -75,3 +75,19 @@ If you are familiar with `JSON`, you can implement the preset or field yourself.
7575
For more details on adding presets, see ["Making changes"](./CONTRIBUTING.md#making-changes).
7676

7777
If you are not familiar with `JSON`, still create a ticket. The more you have considered and prepared from the above steps, the easier it will be for someone else to code it.
78+
79+
### File Name Conventions and Directory Structure
80+
81+
The folder structure and file names of the presets and fields closely follows the main `tags` of the respective files.
82+
* For example, the preset for `natural=tree` is defined in the file `tree.json` in the directory `data/presets/natural`.
83+
* For presets with more than one tag, the directory structure is nested: e.g. the preset for `highway=service + service=driveway` is included as `highway/service/driveway.json`.
84+
* Unsearchable presets are defined in a file name starting with an underscore.
85+
* Regional presets or fields should be suffixed with a dash and the respective region codes where they are applied, the "default" preset for the rest of the world is kept without a suffix (e.g. `royal_cypher-GB.json`).
86+
* If reasonable, avoid renaming or moving files when altering the tags of a presets: because translations and some external datasets (e.g. [NSI](https://github.com/osmlab/name-suggestion-index)) are referencing presets by their file and directory name as an identifier, every time a preset or field file is renamed or moved, existing translations are lost and external references potentially broken. If a file name really need to be changed, consider the following approach to limit the impact of the identifier change:
87+
1. add a placeholder preset with the file name and directory as the preset's previous version that is:
88+
* not searchable
89+
* references the strings and fields of the new preset or field
90+
* has a low matchscore
91+
2. after the id-tagging-schema release that includes the id change: notify upstream consumers of the data (e.g. NSI) about the change and ask them to update their ids to the new ids
92+
3. delete the placeholder presets some time after all relevant upstream data was updated and released
93+

data/deprecated.json

Lines changed: 8 additions & 96 deletions
Original file line numberDiff line numberDiff line change
@@ -1257,102 +1257,6 @@
12571257
"old": {"parking": "street"},
12581258
"replace": {"parking": "lane"}
12591259
},
1260-
{
1261-
"old": {"parking:lane:both": "no"},
1262-
"replace": {"parking:both": "no"}
1263-
},
1264-
{
1265-
"old": {"parking:lane:both": "no_parking"},
1266-
"replace": {"parking:both": "no", "parking:both:restriction": "no_parking"}
1267-
},
1268-
{
1269-
"old": {"parking:lane:both": "no_stopping"},
1270-
"replace": {"parking:both": "no", "parking:both:restriction": "no_stopping"}
1271-
},
1272-
{
1273-
"old": {"parking:lane:both": "fire_lane"},
1274-
"replace": {"parking:both": "no", "parking:both:restriction": "no_stopping", "parking:both:restriction:reason": "fire_lane"}
1275-
},
1276-
{
1277-
"old": {"parking:lane:both": "separate"},
1278-
"replace": {"parking:both": "separate"}
1279-
},
1280-
{
1281-
"old": {"parking:lane:both": "diagonal"},
1282-
"replace": {"parking:both": "yes", "parking:both:orientation": "diagonal"}
1283-
},
1284-
{
1285-
"old": {"parking:lane:both": "parallel"},
1286-
"replace": {"parking:both": "yes", "parking:both:orientation": "parallel"}
1287-
},
1288-
{
1289-
"old": {"parking:lane:both": "perpendicular"},
1290-
"replace": {"parking:both": "yes", "parking:both:orientation": "perpendicular"}
1291-
},
1292-
{
1293-
"old": {"parking:lane:both:parallel": "on_street"},
1294-
"replace": {"parking:both": "lane"}
1295-
},
1296-
{
1297-
"old": {"parking:lane:left": "no"},
1298-
"replace": {"parking:left": "no"}
1299-
},
1300-
{
1301-
"old": {"parking:lane:left": "no_parking"},
1302-
"replace": {"parking:left": "no", "parking:left:restriction": "no_parking"}
1303-
},
1304-
{
1305-
"old": {"parking:lane:left": "no_stopping"},
1306-
"replace": {"parking:left": "no", "parking:left:restriction": "no_stopping"}
1307-
},
1308-
{
1309-
"old": {"parking:lane:left": "separate"},
1310-
"replace": {"parking:left": "separate"}
1311-
},
1312-
{
1313-
"old": {"parking:lane:left": "diagonal"},
1314-
"replace": {"parking:left": "yes", "parking:left:orientation": "diagonal"}
1315-
},
1316-
{
1317-
"old": {"parking:lane:left": "parallel"},
1318-
"replace": {"parking:left": "yes", "parking:left:orientation": "parallel"}
1319-
},
1320-
{
1321-
"old": {"parking:lane:left": "perpendicular"},
1322-
"replace": {"parking:left": "yes", "parking:left:orientation": "perpendicular"}
1323-
},
1324-
{
1325-
"old": {"parking:lane:right": "no"},
1326-
"replace": {"parking:right": "no"}
1327-
},
1328-
{
1329-
"old": {"parking:lane:right": "no_parking"},
1330-
"replace": {"parking:right": "no", "parking:right:restriction": "no_parking"}
1331-
},
1332-
{
1333-
"old": {"parking:lane:right": "no_stopping"},
1334-
"replace": {"parking:right": "no", "parking:right:restriction": "no_stopping"}
1335-
},
1336-
{
1337-
"old": {"parking:lane:right": "separate"},
1338-
"replace": {"parking:right": "separate"}
1339-
},
1340-
{
1341-
"old": {"parking:lane:right": "diagonal"},
1342-
"replace": {"parking:right": "yes", "parking:right:orientation": "diagonal"}
1343-
},
1344-
{
1345-
"old": {"parking:lane:right": "parallel"},
1346-
"replace": {"parking:right": "yes", "parking:right:orientation": "parallel"}
1347-
},
1348-
{
1349-
"old": {"parking:lane:right": "perpendicular"},
1350-
"replace": {"parking:right": "yes", "parking:right:orientation": "perpendicular"}
1351-
},
1352-
{
1353-
"old": {"parking:lane:right:parallel": "on_street"},
1354-
"replace": {"parking:right": "lane"}
1355-
},
13561260
{
13571261
"old": {"parking:orientation": "*"},
13581262
"replace": {"orientation": "$1"}
@@ -2103,5 +2007,13 @@
21032007
{
21042008
"old": {"cycleway:left": "opposite"},
21052009
"replace": {"oneway:bicycle": "no", "cycleway:left": "no"}
2010+
},
2011+
{
2012+
"old": {"man_made": "torii"},
2013+
"replace": {"man_made": "ceremonial_gate", "ceremonial_gate": "torii"}
2014+
},
2015+
{
2016+
"old": {"man_made": "paifang"},
2017+
"replace": {"man_made": "ceremonial_gate", "ceremonial_gate": "paifang"}
21062018
}
21072019
]

data/fields/address.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"keys": [
88
"addr:block_number",
99
"addr:city",
10-
"addr:block_number",
1110
"addr:conscriptionnumber",
1211
"addr:country",
1312
"addr:county",

data/fields/bath/sand_bath-JP.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"key": "bath:sand_bath",
3+
"label": "Sand Bath",
4+
"type": "check",
5+
"locationSet": {
6+
"include": [
7+
"JP"
8+
]
9+
}
10+
}

data/fields/bath/sand_bath.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

data/fields/boat.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"key": "boat",
3+
"type": "combo",
4+
"label": "Boat Access"
5+
}

0 commit comments

Comments
 (0)