Skip to content

Commit 07d6902

Browse files
committed
TPC23 option needs to be removed in embedding definitions, as it is not used
in standard reconstruction. Below is the history of why it was introduced in the first place, and why it can be retired. The TPC23 option was introduced as a functional workaround for a "heisenbug" in the TPC clustering code during the integration of geant4star and ROOT 6. The Issue: Standard offline reconstruction was incorrectly limiting the number of hits on tracks to approximately 30, whereas the TPC with the iTPC upgrade should have yielded over 70 hits. The Workaround: Enabling the "incorrect but functional" TPC23 clustering algorithm allowed embedding jobs to produce "nice long tracks" and comparable results for tracking performance evaluation, even though the algorithm was technically not the correct one for the 2024/2025 datasets. The Resolution: The underlying issue was identified as a failure in reconstruction to proceed past the first event, which was tied to improper timestamp and run number settings. The Fix: Once the timestamps were properly set to match the specific run numbers (accounting for gaps in TPC tables between runs), the standard reconstruction and clustering began working correctly. Obsolescence: With the timestamp handling fixed, the "incorrect" TPC23 workaround was no longer necessary to achieve proper track lengths in the 2024 and 2025 simulations.
1 parent 591f5a6 commit 07d6902

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

StRoot/macros/embedding/bfcMixer_TpxG4.C

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ void bfcMixer_TpxG4(
358358
chain0opts = opts.loadopts;
359359
chain1opts = opts.chain1 + " nooutput ";
360360
chain2opts = opts.chain2 + " noinput nooutput ";
361-
chain3opts = opts.chain3 + " -in noinput Tpc23 ";
361+
chain3opts = opts.chain3 + " -in noinput ";
362362
bfcMixer_TpxG4();
363363

364364
}

0 commit comments

Comments
 (0)