Skip to content

Commit fe175bc

Browse files
author
Jamie White
committed
Drop support for Ember < 3.4
This commit is, I’ll confess, controversial. However, ember-apollo-client only supports Ember >= 3.4 and it makes our lives *much* easier to follow suit. The real source of the 3.4 minimum is ember-native-class-polyfill which ember-apollo-client now requires Ember < 3.6. As per [the ember-apollo-client 2.0.0 release notes][1]: > If you are using Ember versions 3.4 or 3.5 you must add > ember-native-class-polyfill to your application. [1]: https://github.com/ember-graphql/ember-apollo-client/releases/tag/v2.0.0
1 parent dc4d11c commit fe175bc

2 files changed

Lines changed: 31 additions & 43 deletions

File tree

.travis.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,22 @@ jobs:
4444
- yarn test
4545
- cat coverage/lcov.info | node_modules/coveralls/bin/coveralls.js
4646

47+
- stage: "Additional Tests"
48+
name: "Floating Dependencies"
49+
install:
50+
- yarn install --no-lockfile --non-interactive
51+
script:
52+
- yarn test
53+
4754
# we recommend new addons test the current and previous LTS
4855
# as well as latest stable release (bonus points to beta/canary)
49-
- stage: "Additional Tests"
50-
env: EMBER_TRY_SCENARIO=ember-lts-2.16
51-
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
52-
- env: EMBER_TRY_SCENARIO=ember-lts-3.4
53-
- env: EMBER_TRY_SCENARIO=ember-lts-3.8
56+
- env: EMBER_TRY_SCENARIO=ember-lts-3.12
57+
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
5458
- env: EMBER_TRY_SCENARIO=ember-release
5559
- env: EMBER_TRY_SCENARIO=ember-beta
5660
- env: EMBER_TRY_SCENARIO=ember-canary
5761
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
62+
- env: EMBER_TRY_SCENARIO=ember-classic
5863

5964
script:
6065
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

config/ember-try.js

Lines changed: 21 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -7,45 +7,18 @@ module.exports = async function() {
77
useYarn: true,
88
scenarios: [
99
{
10-
name: 'ember-lts-2.16',
11-
env: {
12-
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
13-
},
14-
npm: {
15-
devDependencies: {
16-
'@ember/jquery': '^0.5.1',
17-
'ember-apollo-client': '2.0.0-beta.1',
18-
'ember-source': '~2.16.0'
19-
}
20-
}
21-
},
22-
{
23-
name: 'ember-lts-2.18',
24-
env: {
25-
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
26-
},
27-
npm: {
28-
devDependencies: {
29-
'@ember/jquery': '^0.5.1',
30-
'ember-apollo-client': '2.0.0-beta.1',
31-
'ember-source': '~2.18.0'
32-
}
33-
}
34-
},
35-
{
36-
name: 'ember-lts-3.4',
10+
name: 'ember-lts-3.12',
3711
npm: {
3812
devDependencies: {
39-
'ember-apollo-client': '2.0.0-beta.1',
40-
'ember-source': '~3.4.0'
13+
'ember-source': '~3.12.0'
4114
}
4215
}
4316
},
4417
{
45-
name: 'ember-lts-3.8',
18+
name: 'ember-lts-3.16',
4619
npm: {
4720
devDependencies: {
48-
'ember-source': '~3.8.0'
21+
'ember-source': '~3.16.0'
4922
}
5023
}
5124
},
@@ -73,31 +46,41 @@ module.exports = async function() {
7346
}
7447
}
7548
},
49+
// The default `.travis.yml` runs this scenario via `yarn test`,
50+
// not via `ember try`. It's still included here so that running
51+
// `ember try:each` manually or from a customized CI config will run it
52+
// along with all the other scenarios.
7653
{
7754
name: 'ember-default',
55+
npm: {
56+
devDependencies: {}
57+
}
58+
},
59+
{
60+
name: 'ember-default-with-jquery',
7861
env: {
7962
EMBER_OPTIONAL_FEATURES: JSON.stringify({
8063
'jquery-integration': true
8164
})
8265
},
8366
npm: {
8467
devDependencies: {
85-
'@ember/jquery': '^0.5.1',
86-
'ember-apollo-client': '2.0.0-beta.1'
68+
'@ember/jquery': '^0.5.1'
8769
}
8870
}
8971
},
9072
{
91-
name: 'ember-default-with-jquery',
73+
name: 'ember-classic',
9274
env: {
9375
EMBER_OPTIONAL_FEATURES: JSON.stringify({
94-
'jquery-integration': true
76+
'application-template-wrapper': true,
77+
'default-async-observers': false,
78+
'template-only-glimmer-components': false
9579
})
9680
},
9781
npm: {
98-
devDependencies: {
99-
'@ember/jquery': '^0.5.1',
100-
'ember-apollo-client': '2.0.0-beta.1'
82+
ember: {
83+
edition: 'classic'
10184
}
10285
}
10386
}

0 commit comments

Comments
 (0)