Skip to content

Add intersection/intersectionWith#96

Merged
chshersh merged 3 commits intokowainik:masterfrom
ChrisPenner:intersection
Oct 27, 2020
Merged

Add intersection/intersectionWith#96
chshersh merged 3 commits intokowainik:masterfrom
ChrisPenner:intersection

Conversation

@ChrisPenner
Copy link
Copy Markdown
Collaborator

@ChrisPenner ChrisPenner commented Oct 4, 2020

Uses some work from #93 ; I.e. this uses the same merge sort strategy, but omits elements that aren't in both maps.

Here's the only new commit

@chshersh chshersh added Hacktoberfest https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept contributions during Hacktoberfest labels Oct 6, 2020
@ChrisPenner
Copy link
Copy Markdown
Collaborator Author

Rebased and ready for review 👍

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisPenner As always, amazing work 💪

I left one comment on how you can fix the CI error. Otherwise, it looks good 👍

Comment thread test/Test/TypeRep/TypeRepMapProperty.hs
@chshersh chshersh mentioned this pull request Oct 16, 2020
@chshersh chshersh added this to the v0.4.0.0: Boost milestone Oct 17, 2020
@chshersh
Copy link
Copy Markdown
Contributor

@ChrisPenner I guess it should be okay to rebase on master now 🙂

Comment thread src/Data/TMap.hs Outdated
Comment thread src/Data/TMap.hs Outdated
Comment thread src/Data/TypeRepMap/Internal.hs Outdated
Comment thread src/Data/TypeRepMap/Internal.hs Outdated
Comment thread src/Data/TMap.hs Outdated
@chshersh
Copy link
Copy Markdown
Contributor

@ChrisPenner Awesome job! Thanks again!
Also, I see that typerep-map gained a few extra stars on GitHub after you've started contributing 🌟 🤩 ⭐
Thanks a lot of improving the project 🙏

@chshersh chshersh merged commit b3c8d19 into kowainik:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept contributions during Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants