fix(config): don't show diagnostics warning with diagnostics: false (#3647)

Fixes #3638

Author: ahnpnl

e2e/diagnostics/__tests__/diagnostics.spec.ts

@@ -1,4 +1,4 @@
-import { Thing } from '../foo'
+import type { Thing } from '../foo'
 
 const thing: Thing = { a: 1 }
 

e2e/utils.ts

@@ -1,7 +1,6 @@
 import * as path from 'path'
 
-import type { Config } from '@jest/types'
-import { ExecaReturnValue, sync as spawnSync, SyncOptions } from 'execa'
+import { type ExecaReturnValue, sync as spawnSync, type SyncOptions } from 'execa'
 import * as fs from 'graceful-fs'
 
 import { version } from '../package.json'
@@ -12,7 +11,7 @@ interface RunResult extends ExecaReturnValue {
   status: number
   error: Error
 }
-export const run = (cmd: string, cwd?: Config.Path, env?: Record<string, string>): RunResult => {
+export const run = (cmd: string, cwd?: string, env?: Record<string, string>): RunResult => {
   const args = cmd.split(/\s/).slice(1)
   const spawnOptions = { cwd, env, preferLocal: false, reject: false }
   const result = spawnSync(cmd.split(/\s/)[0], args, spawnOptions as SyncOptions) as RunResult
@@ -34,7 +33,7 @@ export const run = (cmd: string, cwd?: Config.Path, env?: Record<string, string>
   return result
 }
 
-export const runNpmInstall = (cwd: Config.Path, env?: Record<string, string>): RunResult => {
+export const runNpmInstall = (cwd: string, env?: Record<string, string>): RunResult => {
   const lockfilePath = path.resolve(cwd, 'package-lock.json')
   let exists = true
 

src/legacy/config/config-set.spec.ts

@@ -539,6 +539,18 @@ describe('raiseDiagnostics', () => {
         ]
       `)
     })
+
+    it('should not throw when diagnostics is false', () => {
+      const cs = createConfigSet({
+        filterDiagnostics,
+        logger,
+        tsJestConfig: { diagnostics: false },
+      })
+
+      logger.target.clear()
+      expect(() => cs.raiseDiagnostics([])).not.toThrow()
+      expect(() => cs.raiseDiagnostics([makeDiagnostic()])).not.toThrow()
+    })
   })
 
   describe("diagnostics don't contain source file", () => {

src/legacy/config/config-set.ts

@@ -295,9 +295,13 @@ export class ConfigSet {
         throws: diagnosticsOpt,
       }
     }
-    this._shouldIgnoreDiagnosticsForFile = this._diagnostics.exclude.length
-      ? globsToMatcher(this._diagnostics.exclude)
-      : () => false
+    if (diagnosticsOpt) {
+      this._shouldIgnoreDiagnosticsForFile = this._diagnostics.exclude.length
+        ? globsToMatcher(this._diagnostics.exclude)
+        : () => false
+    } else {
+      this._shouldIgnoreDiagnosticsForFile = () => true
+    }
 
     this.logger.debug({ diagnostics: this._diagnostics }, 'normalized diagnostics config via ts-jest option')