feat(config): specify package.json location (#823)#1013
Merged
GeeWee merged 3 commits intokulshekhar:masterfrom Mar 14, 2019
Merged
feat(config): specify package.json location (#823)#1013GeeWee merged 3 commits intokulshekhar:masterfrom
GeeWee merged 3 commits intokulshekhar:masterfrom
Conversation
Pull Request Test Coverage Report for Build 2523
💛 - Coveralls |
Collaborator
|
Hi, would you please link to a related issue in the description or from any discussions ? |
Contributor
Author
Collaborator
|
This looks good to me. Can you update the docs as well? |
Document the package.json config option.
ahnpnl
approved these changes
Mar 12, 2019
Collaborator
|
Once your branch is in sync with master, we can merge this PR 👍 |
Collaborator
|
I think we can merge this @GeeWee @kulshekhar |
Contributor
Author
|
Please let me know if you'd like me to rebase+push instead of the merge commit. Thanks! |
Collaborator
|
Perfectly fine as is. Thanks for your contribution! |
Owner
|
Sorry for the delay. A new version has now been published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues #823 and #852