fix: jest 25 type definitions#1363
Merged
kulshekhar merged 1 commit intokulshekhar:masterfrom Jan 29, 2020
Merged
Conversation
A lot of the Jest typings were moved into the core repo rather than the `@types/jest` definitions. See DefinitelyTyped/DefinitelyTyped@ef7406a
Pull Request Test Coverage Report for Build 3914
💛 - Coveralls |
Collaborator
|
thanks for your PR, LGTM 👍 |
ahnpnl
approved these changes
Jan 28, 2020
kulshekhar
requested changes
Jan 29, 2020
kulshekhar
approved these changes
Jan 29, 2020
Owner
|
@AndrewLeedham thanks! |
Contributor
Author
|
@kulshekhar will this trigger an npm release? |
Owner
|
@AndrewLeedham no. I'll have to do that manually. I'll try to do it later today |
SimenB
reviewed
Mar 31, 2020
| @@ -1,12 +1,15 @@ | |||
| import { TransformOptions, TransformedSource } from '@jest/transform/build/types' | |||
Contributor
There was a problem hiding this comment.
Please send PRs for any types you need that are not exported at the top level of the module. Reaching into build/ is not supported and can break at any time
Collaborator
There was a problem hiding this comment.
do you mean FR and PRs ?
Contributor
There was a problem hiding this comment.
In this case, we already export TransformOptions at least. TransformedSource is not exported though (ReturnType<Transformer['process']> is clunky), so PR for that is welcome
https://www.runpkg.com/?@jest/transform@25.2.4/build/index.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of the Jest typings were moved into the core repo rather than the
@types/jestdefinitions. See DefinitelyTyped/DefinitelyTyped@ef7406afixes: #1362