Let babel-jest handle loading babel config#1370
Merged
kulshekhar merged 8 commits intokulshekhar:masterfrom Feb 3, 2020
ahnpnl:fix/load-babel-config
Merged
Let babel-jest handle loading babel config#1370kulshekhar merged 8 commits intokulshekhar:masterfrom ahnpnl:fix/load-babel-config
kulshekhar merged 8 commits intokulshekhar:masterfrom
ahnpnl:fix/load-babel-config
Conversation
Pull Request Test Coverage Report for Build 3951
💛 - Coveralls |
kulshekhar
reviewed
Feb 3, 2020
Owner
kulshekhar
left a comment
There was a problem hiding this comment.
This looks good to me. What problems do you anticipate with this change @ahnpnl ?
kulshekhar
approved these changes
Feb 3, 2020
Collaborator
Author
|
we now only collect any babel configs we can and pass them to |
Owner
|
ok. Let's merge this in then. I'll push a new release later today after that |
Collaborator
Author
|
ok let's proceed like that |
Owner
|
pushing a release out shortly. aside: @ahnpnl when you get the chance, could you please check the message I've sent on slack? |
Contributor
|
Yup, letting |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1341
Note: this needs to be well tested because it looks to me like a breaking change.