fix: only do type checking while compiling file#1483
Merged
ahnpnl merged 7 commits intokulshekhar:masterfrom Apr 2, 2020
ahnpnl:fix-diagnostics
Merged
fix: only do type checking while compiling file#1483ahnpnl merged 7 commits intokulshekhar:masterfrom ahnpnl:fix-diagnostics
ahnpnl merged 7 commits intokulshekhar:masterfrom
ahnpnl:fix-diagnostics
Conversation
Pull Request Test Coverage Report for Build 4292
💛 - Coveralls |
kulshekhar
reviewed
Apr 2, 2020
Owner
kulshekhar
left a comment
There was a problem hiding this comment.
@ahnpnl thanks for pushing this fix! I've just left some comments for minor, cosmetic issues
kulshekhar
approved these changes
Apr 2, 2020
This was referenced Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1470
revert #1472 and #1450
Background
In #1450 , we moved the type checking part to
getCacheKey. However, this cost performance because ts compiler will do extra diagnostics check and cache them for files which are not the wanted-compiled files.Changes
This PR does several things:
$$ts-jestwhenallowJsis enabled withoutoutDir#1472Caveat
There will be a slight decrease in performance since we need to do extra diagnostics check not only for test file which has changed imported modules but also the changed module to solve #1390