Skip to content

fix: only do type checking while compiling file#1483

Merged
ahnpnl merged 7 commits intokulshekhar:masterfrom
ahnpnl:fix-diagnostics
Apr 2, 2020
Merged

fix: only do type checking while compiling file#1483
ahnpnl merged 7 commits intokulshekhar:masterfrom
ahnpnl:fix-diagnostics

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented Apr 1, 2020

closes #1470
revert #1472 and #1450

Background
In #1450 , we moved the type checking part to getCacheKey. However, this cost performance because ts compiler will do extra diagnostics check and cache them for files which are not the wanted-compiled files.

Changes
This PR does several things:

Caveat
There will be a slight decrease in performance since we need to do extra diagnostics check not only for test file which has changed imported modules but also the changed module to solve #1390

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 1, 2020

Pull Request Test Coverage Report for Build 4292

  • 46 of 46 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.795%

Totals Coverage Status
Change from base Build 4290: -0.2%
Covered Lines: 1146
Relevant Lines: 1182

💛 - Coveralls

@ahnpnl ahnpnl requested a review from kulshekhar April 1, 2020 20:22
Copy link
Copy Markdown
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahnpnl thanks for pushing this fix! I've just left some comments for minor, cosmetic issues

Comment thread e2e/__cases__/isolated-modules/main.ts Outdated
Comment thread e2e/__cases__/diagnostics/main.ts Outdated
Comment thread src/compiler/instance.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Performance after upgrading from 25.2.1 to 25.3.0

3 participants