fix(config): set default outDir when allowJs is true and no outDir in tsconfig#1502
Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom Apr 4, 2020
ahnpnl:allow-js-fix
Merged
fix(config): set default outDir when allowJs is true and no outDir in tsconfig#1502ahnpnl merged 1 commit intokulshekhar:masterfrom ahnpnl:allow-js-fix
outDir when allowJs is true and no outDir in tsconfig#1502ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:allow-js-fix
Conversation
ahnpnl
changed the title
outDir when allowJs is true and no outDir in tsconfig
kulshekhar
approved these changes
Apr 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring back changes in #1472 , close #1500
Test plan
Added unit tests and e2e tests
Green CI
Does this PR introduce a breaking change?
Other information
N.A.