fix(compiler): make sure LanguageService updated with test file information before getting diagnostics for test file#1507
Merged
ahnpnl merged 3 commits intokulshekhar:masterfrom Apr 7, 2020
ahnpnl:fix-compiler
Merged
fix(compiler): make sure LanguageService updated with test file information before getting diagnostics for test file#1507ahnpnl merged 3 commits intokulshekhar:masterfrom ahnpnl:fix-compiler
LanguageService updated with test file information before getting diagnostics for test file#1507ahnpnl merged 3 commits intokulshekhar:masterfrom
ahnpnl:fix-compiler
Conversation
ahnpnl
changed the title
LanguageService updated with test file information before getting diagnostics for test file
kulshekhar
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #1483, we introduced caching imported modules for test files and use that cache to do type checking for test files once one of the imported modules' contents changes.
However, this causes a bug that when running tests with cache and one of the imported modules' contents changes, language service sometimes doesn't have the information of the test file to do type checking which then throws error
Cannot find source file .....close #1506
close #1523
Test plan
Does this PR introduce a breaking change?
Other information
N.A.