chore(compiler): improve performance for isolatedModules: false#1558
Merged
ahnpnl merged 7 commits intokulshekhar:25.xfrom Apr 22, 2020
ahnpnl:improve-performance-1
Merged
chore(compiler): improve performance for isolatedModules: false#1558ahnpnl merged 7 commits intokulshekhar:25.xfrom ahnpnl:improve-performance-1
isolatedModules: false#1558ahnpnl merged 7 commits intokulshekhar:25.xfrom
ahnpnl:improve-performance-1
Conversation
Pull Request Test Coverage Report for Build 4504
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve performance for
isolatedModules: falseby only creatingLanguageServiceinstance with limited amount of initial files.Because when creating
LanguageServiceinstance withfileNamesfromtsconfig, often thisfileNamesincludes all the files in the project which makes internal TypeScript performs scanning and reading the unnecessary files. This is not optimal because it will create lots of I/O threads which then impact heavily on the performance.This PR should help #1115 and all related performance issues by somewhere around 30% improvement in speed.
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.