fix(compiler): allow using files provided by tsconfig#1562
Merged
Conversation
Pull Request Test Coverage Report for Build 4529
💛 - Coveralls |
ahnpnl
force-pushed
the
allow-specific-files-tsconfig
branch
from
5d04151 to
0d9913b
Compare
ahnpnl
force-pushed
the
allow-specific-files-tsconfig
branch
from
0d9913b to
24b5726
Compare
kulshekhar
approved these changes
Apr 25, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 27, 2020
BREAKING CHANGE:
Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.
For example
```
// tsconfig.json
{
// ...other configs
"files": [
"my-custom-typings.d.ts".
"my-global-module.ts"
]
}
```
ahnpnl
added a commit
that referenced
this pull request
Apr 28, 2020
BREAKING CHANGE:
Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.
For example
```
// tsconfig.json
{
// ...other configs
"files": [
"my-custom-typings.d.ts".
"my-global-module.ts"
]
}
```
ahnpnl
added a commit
that referenced
this pull request
Apr 28, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
ahnpnl
added a commit
that referenced
this pull request
Apr 29, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
ahnpnl
added a commit
that referenced
this pull request
Apr 29, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
ahnpnl
added a commit
that referenced
this pull request
Apr 30, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
ahnpnl
added a commit
that referenced
this pull request
May 1, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
ahnpnl
added a commit
that referenced
this pull request
May 1, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
ahnpnl
added a commit
that referenced
this pull request
May 4, 2020
…g` (#1562) BREAKING CHANGE: Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`. For example ``` // tsconfig.json { // ...other configs "files": [ "my-custom-typings.d.ts". "my-global-module.ts" ] } ```
2 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includereceived fromtsconfigto an empty array to avoid loading unnecessary files to utilise incremental feature ofLanguageService.This will fix an issue with custom typings mentioned in #1115 (comment)
Test plan
Added unit test and e2e test
Green CI
Does this PR introduce a breaking change?
Because of setting
includeto an empty array to improve performance forisolatedModules: false, any custom typing files which are intended to use withjestneed to be defined infilesoption oftsconfig.For example
Other information
N.A.