fix(config): don't set include property value of tsconfig to empty array#1606
Merged
ahnpnl merged 1 commit intokulshekhar:v25.5.1from May 7, 2020
ahnpnl:v25.5.1
Merged
fix(config): don't set include property value of tsconfig to empty array#1606ahnpnl merged 1 commit intokulshekhar:v25.5.1from ahnpnl:v25.5.1
ahnpnl merged 1 commit intokulshekhar:v25.5.1from
ahnpnl:v25.5.1
Conversation
Collaborator
Author
|
@kulshekhar #1562 made lots of users happy but also lots of users not happy. Since the scale of breaking is quite large and it brings up some inconvenience, it's safer to revert #1562. This PR is a hotfix 25.5.1. Later I will also merge this into master for 26 as well. |
Pull Request Test Coverage Report for Build 4716
💛 - Coveralls |
ahnpnl
commented
May 7, 2020
| } | ||
| ``` | ||
|
|
||
| ## Caveats |
Collaborator
Author
There was a problem hiding this comment.
not sure if writing like this is fine. Would you please check ?
Owner
There was a problem hiding this comment.
This looks fine. It's basically your opinion on how this could be helpful under specific conditions. Nothing wrong with it
kulshekhar
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert fix(compiler): allow using files provided by tsconfig #1562
Add doc to instruct how to boost performance and caveats
Close #1604
Close #1607
Close #1608
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.