Skip to content

fix(typing): don't mark BabelConfig as internal type#1667

Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:expose-babel-config-type
May 21, 2020
Merged

fix(typing): don't mark BabelConfig as internal type#1667
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:expose-babel-config-type

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented May 21, 2020

Summary

Close #1666

Test plan

Test against the repo in #1666

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also lock typescript at 3.x in package.json

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 21, 2020 08:57
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4899

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.826%

Totals Coverage Status
Change from base Build 4898: 0.0%
Covered Lines: 1060
Relevant Lines: 1095

💛 - Coveralls

@ahnpnl ahnpnl merged commit 558c307 into kulshekhar:master May 21, 2020
@ahnpnl ahnpnl deleted the expose-babel-config-type branch May 21, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ts-jest/dist/types.d.ts:15:38 - error TS2304: Cannot find name 'BabelConfig'.

3 participants