feat(config): add support for multiple paths in module name mapper#1690
feat(config): add support for multiple paths in module name mapper#1690ahnpnl merged 2 commits intokulshekhar:masterfrom
Conversation
Pull Request Test Coverage Report for Build 4990
💛 - Coveralls |
|
hi, thank you for your PR. In general the PR LGTM. Just extra requests:
|
|
I have no idea how an e2e test should look like. Also I don't think there is any need for updating docs because it never explained the method's implementation details. |
|
You can put the example of using this function in external-repos. In that folder, there are several independent projects. You can adjust one project to have this function in use. That would be sufficient enough. To test the changes in external-repos, you can run test:external-repos script which can be found in package.json Regarding to documentation, it can be excluded from this PR. |
|
I added e2e tests, thanks for guiding me. Also rebased the master. I hope it passes the quality control this time :] |
There was a problem hiding this comment.
thanks 👍 LGTM
@kulshekhar please have a look once
kulshekhar
left a comment
There was a problem hiding this comment.
Looks good to me as well. Thanks @OrkhanAlikhanov 😃
Summary
Closes #1072
Does this PR introduce a breaking change?