Skip to content

fix: revert #1793#1804

Merged
ahnpnl merged 1 commit intomasterfrom
ahnpnl-patch-1
Jul 14, 2020
Merged

fix: revert #1793#1804
ahnpnl merged 1 commit intomasterfrom
ahnpnl-patch-1

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented Jul 14, 2020

Fixes #1793 (comment)

Seems like GCF has its own configuration to for strict node version which we cannot reproduce with local environment. It's better that revert the change so all environments will work.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 14, 2020 08:24
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5359

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.721%

Totals Coverage Status
Change from base Build 5357: 0.0%
Covered Lines: 1056
Relevant Lines: 1091

💛 - Coveralls

@ahnpnl ahnpnl merged commit 5095525 into master Jul 14, 2020
@ahnpnl ahnpnl deleted the ahnpnl-patch-1 branch July 14, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants