fix(compiler): check if test file exists before doing type check#1827
Merged
ahnpnl merged 1 commit intokulshekhar:v26.1.4from Jul 25, 2020
ahnpnl:v26.1.4
Merged
fix(compiler): check if test file exists before doing type check#1827ahnpnl merged 1 commit intokulshekhar:v26.1.4from ahnpnl:v26.1.4
ahnpnl merged 1 commit intokulshekhar:v26.1.4from
ahnpnl:v26.1.4
Conversation
Pull Request Test Coverage Report for Build 5427
💛 - Coveralls |
kulshekhar
approved these changes
Jul 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressed in #1506 (comment)
The problem is that the test file can be renamed which then makes the link between the imported module with the old test name no longer valid. Therefore we need to check whether the test file still exists before doing type check.
Test plan
Added unit test
Does this PR introduce a breaking change?
Other information
Will release alpha first and then hot fix release later