feat(config): support after and afterDeclarations AST transformers#1831
Merged
ahnpnl merged 2 commits intokulshekhar:masterfrom Jul 28, 2020
ahnpnl:ast-transformer-more-support
Merged
feat(config): support after and afterDeclarations AST transformers#1831ahnpnl merged 2 commits intokulshekhar:masterfrom ahnpnl:ast-transformer-more-support
ahnpnl merged 2 commits intokulshekhar:masterfrom
ahnpnl:ast-transformer-more-support
Conversation
Pull Request Test Coverage Report for Build 5459
💛 - Coveralls |
Collaborator
Author
|
Hmm gonna a few extra tests as not all added codes are covered |
Collaborator
Author
|
look good now, all new added codes are covered :) |
kulshekhar
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At the moment, we only support
beforeAST transformers. There are 2 other types,afterandafterDeclarationswhich we should support too. This PR does:Deprecate current way of defining
astTransformersints-jestconfig by showing a warning message and instruct users how to migrate to the new way of config.Replace the current way of defining
astTransformerswith a new way, which is an object to be able to accept all 3 types of AST transformers.The old way of configuring will be removed in v27
Test plan
Added unit tests and e2e tests, Green CI
Does this PR introduce a breaking change?
Other information
N.A.