perf(transformer): remove createProgram from transpiler #1941
Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom Sep 11, 2020
Merged
perf(transformer): remove createProgram from transpiler #1941ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl merged 1 commit intokulshekhar:masterfrom
Conversation
21dd0aa to
c8f32bc
Compare
Collaborator
|
this is strange, unless something call The reason why I agree that we can remove it. |
Pull Request Test Coverage Report for Build 5859
💛 - Coveralls |
ahnpnl
approved these changes
Sep 11, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I found that Typescript's
createProgramAPI is called even whenisolatedModuleis set.This is a major slow down (100 msecs vs 10~50 secs) for test start up and it doesn't seem to make sense for
isolatedModuleanyway.Longer test start up -> longer feedback cycle -> lower productivity.
Test plan
N/A. The
programisn't used by any part of ts-jest, at least not in its critical path.Does this PR introduce a breaking change?
I just don't know enough about the use case of
programforisolatedModule.Other information
I tried to gather the history around this but couldn't find any notes regarding
transpiler's need forprogram.If the
createProgramturned out to be desirable thing here, I am happy to create another PR to introduce a flag to disable it.Otherwise, I believe majority of
isolatedModuleusers will benefit from this PR greatly.