fix(utils): revert path.join and add check on prefix ends with /#1989
Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom Sep 29, 2020
ahnpnl:fix-test-utils
Merged
fix(utils): revert path.join and add check on prefix ends with /#1989ahnpnl merged 1 commit intokulshekhar:masterfrom ahnpnl:fix-test-utils
path.join and add check on prefix ends with /#1989ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:fix-test-utils
Conversation
Pull Request Test Coverage Report for Build 6001
💛 - Coveralls |
kulshekhar
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1982
Test plan
Adjusted unit tests and e2e tests
Does this PR introduce a breaking change?
Other information
N.A.