Skip to content

fix: burst cache when file’s deps change#2167

Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:typecheck-watch
Dec 7, 2020
Merged

fix: burst cache when file’s deps change#2167
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:typecheck-watch

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented Dec 3, 2020 •
edited
Loading

Summary

Construct cache key with additional information is resolved module name + resolved module's last modified time. When one of imported modules of a file changes, the file needs to be reprocessed to have type check properly

Closes #1122

Test plan

Added unit tests, green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 404733811

  • 60 of 60 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.673%
Totals Coverage Status
Change from base Build 402903131: 0.001%
Covered Lines: 940
Relevant Lines: 970
💛 - Coveralls

@ahnpnl ahnpnl changed the title fix(compiler): use module resolution to detect when to reprocess files fix(compiler): burst cache when file’s deps change Dec 5, 2020
@ahnpnl ahnpnl changed the title fix(compiler): burst cache when file’s deps change fix: burst cache when file’s deps change Dec 5, 2020
@ahnpnl
fix: burst cache when file’s deps change
5bf3b27 
Construct cache key with additional information is resolved module name + resolved module's last modified time. When one of imported modules of a file changes, the file needs to be reprocessed to have type check properly

Closes #2118
Closes #1122
Closes #943
@ahnpnl ahnpnl closed this Dec 7, 2020
@ahnpnl ahnpnl deleted the typecheck-watch branch December 7, 2020 00:51
@ahnpnl ahnpnl restored the typecheck-watch branch December 7, 2020 00:51
@ahnpnl ahnpnl reopened this Dec 7, 2020
@ahnpnl ahnpnl marked this pull request as ready for review December 7, 2020 01:05
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner December 7, 2020 01:05
@ahnpnl ahnpnl added this to the ts-jest v27 milestone Dec 7, 2020
@ahnpnl ahnpnl merged commit ec70365 into kulshekhar:master Dec 7, 2020
@ahnpnl ahnpnl deleted the typecheck-watch branch December 7, 2020 08:17
@ahnpnl ahnpnl mentioned this pull request Jan 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jest --watchAll with ts-jest cannot find property/function if it was defined after its corresponding test case

3 participants

@ahnpnl @coveralls @kulshekhar
⚡