Merged
Conversation
Collaborator
|
Yes there are a few breaking changes for transformer requiring some changes in |
ahnpnl
reviewed
Dec 6, 2020
ahnpnl
reviewed
Dec 6, 2020
Collaborator
|
The version checking should be changed too ts-jest/src/utils/version-checkers.ts Line 13 in 6de7509 If you correct all the comments above + adjust tests, I think that should be enough |
ahnpnl
force-pushed
the
feat/jest-27
branch
5 times, most recently
from
5930de8 to
040652c
Compare
Pull Request Test Coverage Report for Build 409095633
💛 - Coveralls |
ahnpnl
reviewed
Dec 8, 2020
Collaborator
ahnpnl
left a comment
ahnpnl
left a comment
There was a problem hiding this comment.
global.gc is not exposed. jest-jasmine doesn't report correctly error while jest-circus does, see more information here jestjs/jest#9882
| it(`should report correct line numbers`, () => { | ||
| // TODO: Refactor e2e tests to have more stable tests. | ||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip(`should report correct line numbers`, () => { |
Collaborator
There was a problem hiding this comment.
this test is flaky. We need to improve e2e tests setup.
Collaborator
|
@kulshekhar I think we are good in compatibility with jest 27 for this PR. |
ahnpnl
added
the
💣 Breaking Changes
ahnpnl
force-pushed
the
feat/jest-27
branch
2 times, most recently
from
9546334 to
1002708
Compare
BREAKING CHANGE Require minimum jest 27
kulshekhar
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt changes to work with jest 27
Set required jest to
27.0.0-next.2. Later when jest releases27.0.0, we need to update required version to be27.0.0. For now we can temporarily publish with current required version fornexttagDoes this PR introduce a breaking change?
Ohhhhh yeah.