Commit 19f79a7
authored
fix(kumactl): avoid logger issues by importing controller-runtime directly (#13337)
## Motivation & Implementation information
Importing the `controller-runtime/log` subpackage causes global `Log` to
be assigned to the delegated logger, which depends on later `SetLogger`
calls. When `controller-runtime` is also imported elsewhere, this
re-triggers global init logic, leading to data races and inconsistent
logger behavior.
This affects performance and can cause commands like `kumactl install
transparent-proxy` or `kumactl install transparent-proxy-validator` to
hang for several minutes.
By importing `controller-runtime` directly and using its
`Log`/`SetLogger` re-exports, we avoid duplicate initialization and
ordering issues.
## Supporting documentation
Closes: #13299
Signed-off-by: Bart Smykla <bartek@smykla.com>1 parent 5e5e300 commit 19f79a7
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments