fix: add non-finite value validation to time system and limit tempo editor to beat-based time bases

Author: kunstmusik

blue-core/src/main/java/blue/time/TimeDuration.java

@@ -588,6 +588,9 @@ public static final class DurationSeconds extends TimeDuration {
         private final double totalSeconds;
 
         public DurationSeconds(double totalSeconds) {
+            if (!Double.isFinite(totalSeconds)) {
+                throw new IllegalArgumentException("Duration seconds must be finite: " + totalSeconds);
+            }
             if (totalSeconds < 0) {
                 throw new IllegalArgumentException("Duration seconds cannot be negative: " + totalSeconds);
             }

blue-core/src/main/java/blue/time/TimePosition.java

@@ -694,6 +694,9 @@ public static final class SecondsValue extends TimePosition {
         private final double totalSeconds;
 
         public SecondsValue(double totalSeconds) {
+            if (!Double.isFinite(totalSeconds)) {
+                throw new IllegalArgumentException("Seconds must be finite: " + totalSeconds);
+            }
             if (totalSeconds < 0) {
                 throw new IllegalArgumentException("Seconds cannot be negative: " + totalSeconds);
             }

blue-core/src/test/java/blue/time/TimeDurationTest.java

@@ -384,6 +384,19 @@ void testDurationSecondsNegativeRejected() {
             TimeDuration.seconds(-0.001);
         });
     }
+
+    @Test
+    void testDurationSecondsNonFiniteRejected() {
+        assertThrows(IllegalArgumentException.class, () -> {
+            TimeDuration.seconds(Double.NaN);
+        });
+        assertThrows(IllegalArgumentException.class, () -> {
+            TimeDuration.seconds(Double.POSITIVE_INFINITY);
+        });
+        assertThrows(IllegalArgumentException.class, () -> {
+            TimeDuration.seconds(Double.NEGATIVE_INFINITY);
+        });
+    }
 
     // ========== DurationFrames Tests ==========
 

blue-core/src/test/java/blue/time/TimePositionTest.java

@@ -327,6 +327,19 @@ void testSecondsValueNegativeRejected() {
         });
     }
 
+    @Test
+    void testSecondsValueNonFiniteRejected() {
+        assertThrows(IllegalArgumentException.class, () -> {
+            TimePosition.seconds(Double.NaN);
+        });
+        assertThrows(IllegalArgumentException.class, () -> {
+            TimePosition.seconds(Double.POSITIVE_INFINITY);
+        });
+        assertThrows(IllegalArgumentException.class, () -> {
+            TimePosition.seconds(Double.NEGATIVE_INFINITY);
+        });
+    }
+
     @Test
     void testSecondsValueXMLRoundTrip() throws Exception {
         TimePosition original = TimePosition.seconds(12.345678);

blue-ui-core/src/main/java/blue/ui/core/score/tempo/TempoRegionBar.java

@@ -349,7 +349,8 @@ private void showEditTempoDialog(int regionIndex) {
         JPanel positionSection = new JPanel(new BorderLayout(5, 5));
         positionSection.setBorder(BorderFactory.createTitledBorder("Position"));
 
-        SoundObjectTimePanel timePanel = new SoundObjectTimePanel();
+        SoundObjectTimePanel timePanel = new SoundObjectTimePanel(
+                TimeBase.BEATS, TimeBase.BBT, TimeBase.BBST, TimeBase.BBF);
         // Use the actual TimePosition from the tempo point (preserves Measure:Beats if that's how it was entered)
         timePanel.setTimePosition(currentPosition);
         timePanel.setTimeBaseSelectionEnabled(true);

blue-ui-core/src/main/java/blue/ui/core/time/SoundObjectTimePanel.java

@@ -53,11 +53,15 @@ public class SoundObjectTimePanel extends JPanel {
      * Creates a new SoundObjectTimePanel.
      */
     public SoundObjectTimePanel() {
+        this(TimeBase.values());
+    }
+
+    public SoundObjectTimePanel(TimeBase... timeBases) {
         propertyChangeSupport = new PropertyChangeSupport(this);
         setLayout(new BorderLayout());
 
         // TimeBase selector in NORTH
-        timeBaseSelector = new TimeBaseSelector();
+        timeBaseSelector = new TimeBaseSelector(timeBases);
         add(timeBaseSelector, BorderLayout.NORTH);
 
         // Unified text editor for all formats

blue-ui-core/src/main/java/blue/ui/core/time/TimeBaseSelector.java

@@ -38,7 +38,11 @@ public class TimeBaseSelector extends JComboBox<TimeBase> {
      * Creates a new TimeBaseSelector with all available TimeBases.
      */
     public TimeBaseSelector() {
-        super(TimeBase.values());
+        this(TimeBase.values());
+    }
+
+    public TimeBaseSelector(TimeBase... timeBases) {
+        super(timeBases);
         setRenderer(new TimeBaseRenderer());
         // Prevent overly wide preferred/min sizes driven by long display strings
         setPrototypeDisplayValue(TimeBase.BBST);

blue-ui-core/src/main/java/blue/ui/core/time/TimeUnitTextField.java

@@ -510,6 +510,9 @@ private static TimePosition parseSeconds(String text) {
             return TimePosition.SecondsValue.ZERO;
         }
         double seconds = Double.parseDouble(text);
+        if (!Double.isFinite(seconds)) {
+            throw new IllegalArgumentException("Seconds must be finite");
+        }
         if (seconds < 0) {
             throw new IllegalArgumentException("Seconds cannot be negative");
         }

blue-ui-core/src/test/java/blue/ui/core/time/SoundObjectTimePanelTest.java

@@ -0,0 +1,41 @@
+/*
+ * blue - object composition environment for csound
+ * Copyright (C) 2026
+ * Steven Yi <stevenyi@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+package blue.ui.core.time;
+
+import blue.time.TimeBase;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import org.junit.jupiter.api.Test;
+
+class SoundObjectTimePanelTest {
+
+    @Test
+    void testConstructorCanRestrictAvailableTimeBases() {
+        SoundObjectTimePanel panel = new SoundObjectTimePanel(
+                TimeBase.BEATS, TimeBase.BBT, TimeBase.BBST, TimeBase.BBF);
+
+        TimeBaseSelector selector = (TimeBaseSelector) panel.getComponent(0);
+
+        assertEquals(4, selector.getItemCount());
+        assertEquals(TimeBase.BEATS, selector.getItemAt(0));
+        assertEquals(TimeBase.BBT, selector.getItemAt(1));
+        assertEquals(TimeBase.BBST, selector.getItemAt(2));
+        assertEquals(TimeBase.BBF, selector.getItemAt(3));
+    }
+}

blue-ui-core/src/test/java/blue/ui/core/time/TimeUnitTextFieldTest.java

@@ -89,6 +89,21 @@ void testParseSeconds() {
         assertEquals(1.5, parsed.getTotalSeconds(), 0.0001);
     }
 
+    @Test
+    void testParseSecondsRejectsNonFiniteValue() {
+        TimeUnitTextField field = new TimeUnitTextField();
+        field.setTimeBase(TimeBase.SECONDS);
+        field.setTimePosition(TimePosition.seconds(1.5));
+        field.setText("NaN");
+
+        field.postActionEvent();
+
+        TimePosition.SecondsValue parsed = assertInstanceOf(TimePosition.SecondsValue.class,
+                field.getTimePosition());
+        assertEquals(1.5, parsed.getTotalSeconds(), 0.0001);
+        assertEquals("1.5", field.getText());
+    }
+
     @Test
     void testFormatDurationSeconds() {
         TimeUnitTextField field = new TimeUnitTextField();