feat: add replace instrument functionality and update context menu

Author: kunstmusik

blue-ui-core/src/main/java/blue/ui/core/orchestra/ArrangementEditPanel.java

@@ -365,21 +365,54 @@ public void copyInstrument() {
     }
 
     public void pasteInstrument() {
-        Object obj = CopyBuffer.getBufferedObject(CopyBuffer.INSTRUMENT);
+        Instrument clone = getBufferedInstrumentClone();
+
+        if (clone == null) {
+            return;
+        }
+
+        addInstrument(clone);
+    }
+
+    public void replaceInstrument() {
+        int selectedRow = arrangementTable.getSelectedRow();
+        if (arrangement == null || selectedRow < 0) {
+            return;
+        }
+
+        Instrument replacement = getBufferedInstrumentClone();
 
-        if (!(obj instanceof Instrument)) {
+        if (replacement == null) {
             return;
         }
 
-        Instrument instr = (Instrument) obj;
+        String instrumentId = (String) arrangement.getValueAt(selectedRow, 1);
+        Instrument currentInstrument = arrangement.getInstrument(selectedRow);
+
+        arrangement.replaceInstrument(instrumentId, replacement);
+
+        OrchestraEdit edit = new OrchestraEdit(arrangement, currentInstrument,
+                replacement, instrumentId, OrchestraEdit.REPLACE);
+        BlueUndoManager.setUndoManager("orchestra");
+        BlueUndoManager.addEdit(edit);
+
+        arrangementTable.getSelectionModel().setSelectionInterval(selectedRow, selectedRow);
+    }
+
+    private Instrument getBufferedInstrumentClone() {
+        Object obj = CopyBuffer.getBufferedObject(CopyBuffer.INSTRUMENT);
+
+        if (!(obj instanceof Instrument instr)) {
+            return null;
+        }
 
         Instrument clone = instr.deepCopy();
 
         if (clone instanceof BlueSynthBuilder blueSynthBuilder) {
             blueSynthBuilder.clearParameters();
         }
 
-        addInstrument(clone);
+        return clone;
     }
 
     // public void instrumentRemoved(Instrument instr) {
@@ -603,6 +636,9 @@ class InstrumentTablePopup extends JPopupMenu {
         JMenuItem pasteMenuItem = new JMenuItem(BlueSystem
                 .getString("instrument.paste"));
 
+        JMenuItem replaceMenuItem = new JMenuItem(BlueSystem
+            .getString("instrument.replace"));
+
         JMenuItem convertToBSB = new JMenuItem();
 
         Action exportItem;
@@ -620,6 +656,9 @@ public InstrumentTablePopup() {
             pasteMenuItem.addActionListener((ActionEvent e) -> {
                 pasteInstrument();
             });
+            replaceMenuItem.addActionListener((ActionEvent e) -> {
+                replaceInstrument();
+            });
 
             convertToBSB.setText("Convert to BlueSynthBuilder");
             convertToBSB.addActionListener((ActionEvent e) -> {
@@ -727,6 +766,7 @@ public void actionPerformed(ActionEvent e) {
             this.add(cutMenuItem);
             this.add(copyMenuItem);
             this.add(pasteMenuItem);
+            this.add(replaceMenuItem);
             this.addSeparator();
             this.add(convertToBSB);
             this.addSeparator();
@@ -761,6 +801,7 @@ public void popupMenuWillBecomeVisible(PopupMenuEvent e) {
                     Object bufferedObj = CopyBuffer.getBufferedObject(CopyBuffer.INSTRUMENT);
                     boolean bufferFull = (bufferedObj instanceof Instrument);
                     pasteMenuItem.setEnabled(bufferFull);
+                    replaceMenuItem.setEnabled(selected && bufferFull);
                 }
 
                 @Override
@@ -829,19 +870,30 @@ private static class OrchestraEdit extends AbstractUndoableEdit {
 
         public static final int REMOVE = 1;
 
+        public static final int REPLACE = 2;
+
         private final Arrangement arrangement;
 
         private final int type;
 
         private final Instrument instr;
 
+        private final Instrument replacementInstr;
+
         private final String instrId;
 
         public OrchestraEdit(Arrangement arrangement, Instrument instr,
                 String instrId, int type) {
 
+            this(arrangement, instr, null, instrId, type);
+        }
+
+        public OrchestraEdit(Arrangement arrangement, Instrument instr,
+                Instrument replacementInstr, String instrId, int type) {
+
             this.arrangement = arrangement;
             this.instr = instr;
+            this.replacementInstr = replacementInstr;
             this.instrId = instrId;
             this.type = type;
         }
@@ -852,8 +904,10 @@ public void redo() throws CannotRedoException {
 
             if (this.type == ADD) {
                 arrangement.addInstrumentWithId(instr, instrId);
-            } else {
+            } else if (this.type == REMOVE) {
                 arrangement.removeInstrument(instrId);
+            } else {
+                arrangement.replaceInstrument(instrId, replacementInstr);
             }
         }
 
@@ -863,17 +917,21 @@ public void undo() throws CannotUndoException {
 
             if (this.type == ADD) {
                 arrangement.removeInstrument(instrId);
-            } else {
+            } else if (this.type == REMOVE) {
                 arrangement.addInstrumentWithId(instr, instrId);
+            } else {
+                arrangement.replaceInstrument(instrId, instr);
             }
         }
 
         @Override
         public String getPresentationName() {
             if (this.type == ADD) {
                 return "Add Instrument";
+            } else if (this.type == REMOVE) {
+                return "Remove Instrument";
             }
-            return "Remove Instrument";
+            return "Replace Instrument";
         }
     }
 }