Pass lighthouses as command parameter

Author: kurotu

OVRLighthouseManager/Helpers/LighthouseCommands.cs

@@ -199,46 +199,28 @@ public PowerAllCommandOperation Operation
         get; private set;
     }
 
-    private readonly List<LighthouseObject> lighthouses = new();
-
-    public void AddLighthouse(LighthouseObject lighthouse)
-    {
-        if (!lighthouses.Any(x => x == lighthouse))
-        {
-            lighthouses.Add(lighthouse);
-        }
-    }
-
-    public void RemoveLighthouse(LighthouseObject lighthouse)
-    {
-        lighthouses.Remove(lighthouse);
-    }
-
-    public bool CanExecute()
+    public override bool CanExecute(object? parameter)
     {
-        return Operation == PowerAllCommandOperation.None && lighthouses.Any(l => l.IsManaged);
+        var param = parameter as PowerAllCommandParameter;
+        return Operation == PowerAllCommandOperation.None && param.Lighthouses.Any(l => l.IsManaged);
     }
 
-    public override bool CanExecute(object? _) => CanExecute();
-
     public async override Task ExecuteAsync(object? parameter)
     {
         try
         {
-            var command = parameter as string;
+            var param = parameter as PowerAllCommandParameter;
 
-            Operation = command switch
+            Operation = param.Command switch
             {
                 "powerOn" => PowerAllCommandOperation.PowerOn,
                 "powerDown" => PowerAllCommandOperation.PowerDown,
                 _ => PowerAllCommandOperation.None
             };
             CanExecuteChanged?.Invoke(this, EventArgs.Empty);
 
-            var on = command == "powerOn";
-
             var settings = App.GetService<ILighthouseSettingsService>();
-            foreach (var lighthouse in lighthouses.Where(l => l.IsManaged))
+            foreach (var lighthouse in param.Lighthouses.Where(l => l.IsManaged))
             {
                 switch (Operation)
                 {
@@ -270,3 +252,9 @@ public async override Task ExecuteAsync(object? parameter)
         }
     }
 }
+
+public class PowerAllCommandParameter
+{
+    public string Command { get; set; } = string.Empty;
+    public IEnumerable<LighthouseObject> Lighthouses { get; set; } = Enumerable.Empty<LighthouseObject>();
+}

OVRLighthouseManager/ViewModels/MainViewModel.cs

@@ -46,8 +46,8 @@ public partial class MainViewModel : ObservableRecipient
     private readonly PowerAllCommand _powerAllCommand = new();
 
     public ICommand PowerAllCommand => _powerAllCommand;
-    public bool IsDoingPowerOnAll => !_powerAllCommand.CanExecute() && _powerAllCommand.Operation == PowerAllCommandOperation.PowerOn;
-    public bool IsDoingPowerOffAll => !_powerAllCommand.CanExecute() && _powerAllCommand.Operation == PowerAllCommandOperation.PowerDown;
+    public bool IsDoingPowerOnAll => _powerAllCommand.Operation == PowerAllCommandOperation.PowerOn;
+    public bool IsDoingPowerOffAll => _powerAllCommand.Operation == PowerAllCommandOperation.PowerDown;
 
     public MainViewModel(
         ILighthouseDiscoveryService lighthouseService,
@@ -78,7 +78,6 @@ ScanCommand scanCommand
                     var devices = Devices.Select(d => d.Lighthouse).ToArray();
                     await _lighthouseSettingsService.SetDevicesAsync(devices);
                     Log.Information($"Found: {arg.Name} ({AddressToStringConverter.AddressToString(address)})");
-                    _powerAllCommand.AddLighthouse(item);
                 });
             }
             else
@@ -119,7 +118,6 @@ ScanCommand scanCommand
             vm.OnClickRemove += OnClickRemoveDevice;
             vm.OnEditId += OnEditId;
             vm.IsFound = _lighthouseService.FoundLighthouses.Any(l => l.BluetoothAddressValue == AddressToStringConverter.StringToAddress(d.BluetoothAddress));
-            _powerAllCommand.AddLighthouse(vm);
             return vm;
         }).ToArray();
         Devices = new(devices);

OVRLighthouseManager/Views/MainPage.xaml

@@ -10,6 +10,7 @@
     mc:Ignorable="d">
 
     <Page.Resources>
+        <helpers:PowerAllCommandParameter x:Key="PowerAllCommandParameter" />
         <helpers:BooleanToVisibilityConverter x:Key="BooleanToVisibilityConverter" />
     </Page.Resources>
 
@@ -104,8 +105,10 @@
                         Grid.Row="1"
                         x:Name="PowerOnAll"
                         Command="{x:Bind ViewModel.PowerAllCommand}"
-                        CommandParameter="powerOn"
                         >
+                    <Button.CommandParameter>
+                        <helpers:PowerAllCommandParameter Command="powerOn" Lighthouses="{x:Bind ViewModel.Devices, Mode=OneWay}" />
+                    </Button.CommandParameter>
                     <Button.Content>
                         <StackPanel Orientation="Horizontal">
                             <ProgressRing
@@ -125,8 +128,10 @@
                         Grid.Row="1"
                         x:Name="PowerOffAll"
                         Command="{x:Bind ViewModel.PowerAllCommand}"
-                        CommandParameter="powerDown"
                         >
+                    <Button.CommandParameter>
+                        <helpers:PowerAllCommandParameter Command="powerDown" Lighthouses="{x:Bind ViewModel.Devices, Mode=OneWay}" />
+                    </Button.CommandParameter>
                     <Button.Content>
                         <StackPanel Orientation="Horizontal">
                             <ProgressRing