Align unused parameter warnings across compilers (AcademySoftwareFoundation#2577)

As noted in by @bernardkwok in [AcademySoftwareFoundation#2385](AcademySoftwareFoundation#2385). We have divergent compiler warnings and errors. This makes developing on a platform with more relaxed rules than others more difficult. 

This PR adds the `-Wunused-parameter` compiler flat to non-windows platforms to bring things in line.  As well as fixing the warnings raised in the code not previously compiled on Windows.

We could make this change in the opposite direction, where the Windows compile flags are relaxed. I'm open to that, but don't develop on Windows so can't do that work.  If that is the desired direction I would hope we can post a PR for that immediately, or merge this and then revert this change when someone is able to relax the Windows warnings.  The current difference between platforms feels like the worst situation for us all to be in.

Author: ld-kerley

CMakeLists.txt

@@ -287,7 +287,7 @@ if(MSVC)
         add_compile_options(/WX)
     endif()
 else()
-    add_compile_options(-Wall -Wno-missing-braces)
+    add_compile_options(-Wall -Wunused-parameter -Wno-missing-braces)
     if(MATERIALX_WARNINGS_AS_ERRORS)
         add_compile_options(-Werror)
     endif()

source/MaterialXGraphEditor/CMakeLists.txt

@@ -9,9 +9,9 @@ endif()
 if(MSVC)
     add_compile_options(-wd4100 -wd4152 -wd4201 -wd4244 -wd4456)
 elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Wno-unused -Wno-deprecated -Wno-comment -Wno-unused-variable)
+    add_compile_options(-Wno-unused -Wno-deprecated -Wno-comment -Wno-unused-variable -Wno-unused-parameter)
 elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
-    add_compile_options(-Wno-format-truncation -Wno-use-after-free -Wno-comment -Wno-unused-but-set-variable)
+    add_compile_options(-Wno-format-truncation -Wno-use-after-free -Wno-comment -Wno-unused-but-set-variable -Wno-unused-parameter)
 endif()
 
 file(GLOB materialx_source "${CMAKE_CURRENT_SOURCE_DIR}/*.cpp")

source/MaterialXRenderGlsl/GLCocoaWrappers.m

@@ -11,7 +11,7 @@
 
 void* NSOpenGLChoosePixelFormatWrapper(bool allRenders, int bufferType, int colorSize, int depthFormat,
                                 int stencilFormat, int auxBuffers, int accumSize, bool minimumPolicy,
-                                bool accelerated, bool mp_safe,  bool stereo, bool supportMultiSample)
+                                bool accelerated, bool /*mp_safe*/,  bool /*stereo*/, bool supportMultiSample)
 {
     // Create local autorelease pool for any objects that need to be autoreleased.
     NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];

source/MaterialXRenderHw/SimpleWindowIOS.cpp

@@ -21,8 +21,8 @@ SimpleWindow::SimpleWindow() :
     windowCount++;
 }
 
-bool SimpleWindow::initialize(const char* title,
-                              unsigned int width, unsigned int height,
+bool SimpleWindow::initialize(const char* /*title*/,
+                              unsigned int /*width*/, unsigned int /*height*/,
                               void* /*applicationShell*/)
 {
     _windowWrapper = WindowWrapper::create(nullptr);

source/MaterialXRenderHw/WindowWrapper.cpp

@@ -80,8 +80,8 @@ void WindowWrapper::release()
 #elif defined(__APPLE__)
 
 WindowWrapper::WindowWrapper(ExternalWindowHandle externalHandle,
-                             InternalWindowHandle internalHandle,
-                             DisplayHandle display)
+                             InternalWindowHandle /*internalHandle*/,
+                             DisplayHandle /*display*/)
 {
     _externalHandle = externalHandle;
 #ifndef TARGET_OS_IPHONE

source/MaterialXRenderMsl/MslMaterial.mm

@@ -167,7 +167,7 @@
     }
 }
 
-void MslMaterial::bindImages(ImageHandlerPtr imageHandler, const FileSearchPath& searchPath, bool enableMipmaps)
+void MslMaterial::bindImages(ImageHandlerPtr /*imageHandler*/, const FileSearchPath& /*searchPath*/, bool enableMipmaps)
 {
     if (!_glProgram)
     {
@@ -181,7 +181,7 @@
 }
 
 ImagePtr MslMaterial::bindImage(const FilePath& filePath,
-                                const std::string& uniformName,
+                                const std::string& /*uniformName*/,
                                 ImageHandlerPtr imageHandler,
                                 const ImageSamplingProperties& samplingProperties)
 {

source/MaterialXRenderMsl/MslPipelineStateObject.mm

@@ -325,7 +325,7 @@ int GetStrideOfMetalType(MTLDataType type)
 
 void MslProgram::prepareUsedResources(id<MTLRenderCommandEncoder> renderCmdEncoder,
                                       CameraPtr cam,
-                                      GeometryHandlerPtr geometryHandler,
+                                      GeometryHandlerPtr /*geometryHandler*/,
                                       ImageHandlerPtr imageHandler,
                                       LightHandlerPtr lightHandler)
 {

source/MaterialXTest/MaterialXGenMsl/CompileMsl.mm

@@ -13,7 +13,7 @@
 #import <Metal/Metal.h>
 id<MTLDevice> device = nil;
 
-void CompileMslShader(const char* pShaderFilePath, const char* pEntryFuncName)
+void CompileMslShader(const char* pShaderFilePath, const char* /*pEntryFuncName*/)
 {
     NSError* _Nullable error = nil;
     if(device == nil)

source/MaterialXTest/MaterialXRenderMsl/RenderMsl.mm

@@ -165,7 +165,7 @@ bool runRenderer(const std::string& shaderName,
                                           std::ostream& log,
                                           const GenShaderUtil::TestSuiteOptions& testOptions,
                                           RenderUtil::RenderProfileTimes& profileTimes,
-                                          const mx::FileSearchPath& imageSearchPath,
+                                          const mx::FileSearchPath& /*imageSearchPath*/,
                                           const std::string& outputPath,
                                           mx::ImageVec* imageVec)
 {

source/MaterialXView/CMakeLists.txt

@@ -66,9 +66,9 @@ else()
     if(MSVC)
         add_compile_options(-wd4389)
     elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-        add_compile_options(-Wno-deprecated)
+        add_compile_options(-Wno-deprecated -Wno-unused-parameter)
     elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
-        add_compile_options(-Wno-format-truncation -Wno-stringop-overflow -Wno-use-after-free)
+        add_compile_options(-Wno-format-truncation -Wno-stringop-overflow -Wno-use-after-free -Wno-unused-parameter)
     endif()
 
     # Disable NanoGUI compiler modifications for Clang