🖋 The issue about timestamp float precsion fixed using a json_encode instead of (string)

Author: yassinrais

src/Encoding/MicrosecondBasedDateConversion.php

@@ -3,7 +3,6 @@
 
 namespace Lcobucci\JWT\Encoding;
 
-use DateTimeImmutable;
 use Lcobucci\JWT\ClaimsFormatter;
 use Lcobucci\JWT\Token\RegisteredClaims;
 
@@ -19,22 +18,9 @@ public function formatClaims(array $claims): array
                 continue;
             }
 
-            $claims[$claim] = $this->convertDate($claims[$claim]);
+            $claims[$claim] = (float) $claims[$claim]->format('U.u');
         }
 
         return $claims;
     }
-
-    /** @return int|string */
-    private function convertDate(DateTimeImmutable $date)
-    {
-        $seconds      = $date->format('U');
-        $microseconds = $date->format('u');
-
-        if ((int) $microseconds === 0) {
-            return (int) $seconds;
-        }
-
-        return $seconds . '.' . $microseconds;
-    }
 }

src/Token/Parser.php

@@ -12,8 +12,12 @@
 use function count;
 use function explode;
 use function is_array;
+use function is_string;
+use function json_encode;
 use function strpos;
 
+use const JSON_THROW_ON_ERROR;
+
 final class Parser implements ParserInterface
 {
     private Decoder $decoder;
@@ -105,7 +109,9 @@ private function parseClaims(string $data): array
                 continue;
             }
 
-            $claims[$claim] = $this->convertDate((string) $claims[$claim]);
+            $date = $claims[$claim];
+
+            $claims[$claim] = $this->convertDate(is_string($date) ? $date : json_encode($date, JSON_THROW_ON_ERROR));
         }
 
         return $claims;

test/unit/Encoding/ChainedFormatterTest.php

@@ -34,6 +34,6 @@ public function formatClaimsShouldApplyAllConfiguredFormatters(): void
         $formatted = $formatter->formatClaims($claims);
 
         self::assertSame('test', $formatted[RegisteredClaims::AUDIENCE]);
-        self::assertSame('1487285080.123456', $formatted[RegisteredClaims::EXPIRATION_TIME]);
+        self::assertSame(1487285080.123456, $formatted[RegisteredClaims::EXPIRATION_TIME]);
     }
 }

test/unit/Encoding/MicrosecondBasedDateConversionTest.php

@@ -14,7 +14,6 @@ final class MicrosecondBasedDateConversionTest extends TestCase
      * @test
      *
      * @covers ::formatClaims
-     * @covers ::convertDate
      */
     public function dateClaimsHaveMicrosecondsOrSeconds(): void
     {
@@ -35,17 +34,16 @@ public function dateClaimsHaveMicrosecondsOrSeconds(): void
         $formatter = new MicrosecondBasedDateConversion();
         $formatted = $formatter->formatClaims($claims);
 
-        self::assertSame(1487285080, $formatted[RegisteredClaims::ISSUED_AT]);
-        self::assertSame('1487285080.000123', $formatted[RegisteredClaims::NOT_BEFORE]);
-        self::assertSame('1487285080.123456', $formatted[RegisteredClaims::EXPIRATION_TIME]);
+        self::assertSame(1487285080.0, $formatted[RegisteredClaims::ISSUED_AT]);
+        self::assertSame(1487285080.000123, $formatted[RegisteredClaims::NOT_BEFORE]);
+        self::assertSame(1487285080.123456, $formatted[RegisteredClaims::EXPIRATION_TIME]);
         self::assertSame('test', $formatted['testing']); // this should remain untouched
     }
 
     /**
      * @test
      *
      * @covers ::formatClaims
-     * @covers ::convertDate
      */
     public function notAllDateClaimsNeedToBeConfigured(): void
     {
@@ -61,8 +59,8 @@ public function notAllDateClaimsNeedToBeConfigured(): void
         $formatter = new MicrosecondBasedDateConversion();
         $formatted = $formatter->formatClaims($claims);
 
-        self::assertSame(1487285080, $formatted[RegisteredClaims::ISSUED_AT]);
-        self::assertSame('1487285080.123456', $formatted[RegisteredClaims::EXPIRATION_TIME]);
+        self::assertSame(1487285080.0, $formatted[RegisteredClaims::ISSUED_AT]);
+        self::assertSame(1487285080.123456, $formatted[RegisteredClaims::EXPIRATION_TIME]);
         self::assertSame('test', $formatted['testing']); // this should remain untouched
     }
 }

test/unit/Token/ParserTest.php

@@ -453,7 +453,7 @@ public function parseMustConvertDateClaimsToObjects(): void
     {
         $data = [
             RegisteredClaims::ISSUED_AT => 1486930663,
-            RegisteredClaims::EXPIRATION_TIME => '1486930757.023055',
+            RegisteredClaims::EXPIRATION_TIME => 1486930757.023055,
         ];
 
         $this->decoder->expects(self::exactly(2))