Skip to content

Commit 6bfe6a4

Browse files
committed
chore(Order): make CompleteDistribLattice.MinimalAxioms.of semireducible (#37478)
This is part of the greater discussion about whether we should make all `def`s appearing in instances `implicit_reducible`. I believe the answer in this case is pretty clearly yes sinced the sole purpose of `CompleteLattice.MinimalAxioms` is to build instances. From APAP
1 parent 19c4978 commit 6bfe6a4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Mathlib/Order/CompleteBooleanAlgebra.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ variable (minAx : MinimalAxioms α)
224224

225225
/-- The `CompleteDistribLattice.MinimalAxioms` element corresponding to a complete distrib lattice.
226226
-/
227+
@[implicit_reducible]
227228
def of [CompleteDistribLattice α] : MinimalAxioms α where
228229
__ := ‹CompleteDistribLattice α›
229230
inf_sSup_le_iSup_inf a s := inf_sSup_eq.le
@@ -308,6 +309,7 @@ abbrev toCompleteDistribLattice : CompleteDistribLattice.MinimalAxioms α where
308309
_ = _ := by simp [sInf_eq_iInf', iInf_unique, iSup_bool_eq]
309310

310311
/-- The `CompletelyDistribLattice.MinimalAxioms` element corresponding to a frame. -/
312+
@[implicit_reducible]
311313
def of [CompletelyDistribLattice α] : MinimalAxioms α := { ‹CompletelyDistribLattice α› with }
312314

313315
end MinimalAxioms

0 commit comments

Comments
 (0)