Skip to content

Commit aca0e14

Browse files
authored
fix: don't display popups during mouse selection (#615)
This PR ensures that the tooltip hover popup doesn't trigger while the primary mouse button is being held to prevent it from popping up while user are selecting text.
1 parent 44bf3e6 commit aca0e14

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

lean4-infoview/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@leanprover/infoview",
3-
"version": "0.8.4",
3+
"version": "0.8.5",
44
"description": "An interactive display for the Lean 4 theorem prover.",
55
"scripts": {
66
"watch": "rollup --config --environment NODE_ENV:development --watch",

lean4-infoview/src/infoview/tooltips.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,9 @@ export function useHoverTooltip(
280280
}
281281

282282
const onPointerOver = (e: React.PointerEvent<HTMLSpanElement>) => {
283-
if (!isModifierHeld(e)) {
283+
// eslint-disable-next-line no-bitwise
284+
const isSelectionHover = (e.buttons & 1) !== 0
285+
if (!isModifierHeld(e) && !isSelectionHover) {
284286
guardMouseEvent(_ => startShowTimeout(), e)
285287
}
286288
}

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vscode-lean4/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1540,7 +1540,7 @@
15401540
"test": "node ./out/test/suite/runTest.js"
15411541
},
15421542
"dependencies": {
1543-
"@leanprover/infoview": "~0.8.4",
1543+
"@leanprover/infoview": "~0.8.5",
15441544
"@leanprover/infoview-api": "~0.7.0",
15451545
"@leanprover/unicode-input": "~0.1.4",
15461546
"@leanprover/unicode-input-component": "~0.1.4",

0 commit comments

Comments
 (0)