feat: standardize release-please configuration (#106)

* feat: standardize release-please configuration

- Simplify workflow to match ECR pattern by removing custom title logic
- Add include-component-in-tag: false to config for consistency
- Add pull-request-title-pattern for consistent PR titles
- Remove tag-separator to use default behavior
- Maintain current version 0.17.0 in manifest

* fix: pin GitHub Action and Ubuntu versions for security and reliability

- Pin googleapis/release-please-action to v4.2.0 commit hash for security
- Pin Ubuntu runner to ubuntu-22.04 for reliability
- No tag creation or CHANGELOG changes needed (already uses correct format)

* fix: update release-please config to prevent v-prefix in release titles

- Remove include-component-in-tag (redundant)
- Add tag-separator to explicitly control format
- Remove pull-request-title-pattern to avoid interference

* feat: add automatic v-prefix removal from release titles

- Add post-processing step to automatically clean release titles
- Ensures consistent format between git tags and GitHub release titles
- Only runs when release is actually created
- Provides clear logging and smart detection logic

* feat: standardize release-please config format

- Use consistent terraform-module configuration
- Add include-component-in-tag: false for completeness
- Add pull-request-title-pattern for consistency
- Remove tag-separator in favor of standard config

Ensures all repositories follow the same release-please
configuration pattern for terraform modules.

Author: lgallard

.github/workflows/release-please.yml

@@ -7,68 +7,38 @@ on:
 
 jobs:
   release-please:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     outputs:
       release_created: ${{ steps.release_please.outputs.release_created }}
     steps:
-      - uses: googleapis/release-please-action@v4
+      - uses: googleapis/release-please-action@a02a34c4d625f9be7cb89156071d8567266a2445 # v4.2.0
         id: release_please
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           config-file: .release-please-config.json
-      
-      - name: Remove v prefix from release title
+
+      - name: Remove v-prefix from release title
         if: ${{ steps.release_please.outputs.release_created }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          # Get the release ID
-          RELEASE_ID="${{ steps.release_please.outputs.id }}"
-          
-          if [ -z "$RELEASE_ID" ]; then
-            echo "Release ID not found, skipping title update"
-            exit 0
-          fi
-          
-          echo "Processing release ID: $RELEASE_ID"
-          
-          # Get current release data
-          RELEASE_DATA=$(curl -s \
-            -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-            -H "Accept: application/vnd.github.v3+json" \
-            "https://api.github.com/repos/${{ github.repository }}/releases/${RELEASE_ID}")
-          
-          # Extract current title
-          CURRENT_TITLE=$(echo "$RELEASE_DATA" | jq -r '.name')
-          
-          if [ "$CURRENT_TITLE" = "null" ] || [ -z "$CURRENT_TITLE" ]; then
-            echo "Could not retrieve release title, skipping update"
-            exit 0
-          fi
-          
-          echo "Current release title: '$CURRENT_TITLE'"
-          
-          # Remove 'v' prefix if present (case sensitive, only at the beginning, and only if followed by a digit)
-          NEW_TITLE=$(echo "$CURRENT_TITLE" | sed 's/^v\([0-9]\)/\1/')
-          
-          # Only update if the title actually changed
-          if [ "$CURRENT_TITLE" != "$NEW_TITLE" ]; then
-            echo "Updating release title from '$CURRENT_TITLE' to '$NEW_TITLE'"
-            # Use jq to safely construct JSON payload to prevent injection vulnerabilities
-            JSON_PAYLOAD=$(jq -n --arg name "$NEW_TITLE" '{name: $name}')
-            RESPONSE=$(curl -s \
-              -X PATCH \
-              -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-              -H "Accept: application/vnd.github.v3+json" \
-              "https://api.github.com/repos/${{ github.repository }}/releases/${RELEASE_ID}" \
-              -d "$JSON_PAYLOAD")
-            
-            # Check if update was successful
-            UPDATED_TITLE=$(echo "$RESPONSE" | jq -r '.name')
-            if [ "$UPDATED_TITLE" = "$NEW_TITLE" ]; then
-              echo "Successfully updated release title to '$NEW_TITLE'"
-            else
-              echo "Failed to update release title. Response: $RESPONSE"
-              exit 1
-            fi
+          # Get the release tag and current title
+          RELEASE_TAG="${{ steps.release_please.outputs.tag_name }}"
+          echo "Release tag: $RELEASE_TAG"
+
+          # Get current release info
+          CURRENT_RELEASE=$(gh release view "$RELEASE_TAG" --json name,tagName --repo ${{ github.repository }})
+          CURRENT_NAME=$(echo "$CURRENT_RELEASE" | jq -r '.name')
+          echo "Current release name: $CURRENT_NAME"
+
+          # Check if the release title has v-prefix but tag doesn't
+          if [[ "$CURRENT_NAME" =~ ^v[0-9] ]] && [[ ! "$RELEASE_TAG" =~ ^v[0-9] ]]; then
+            # Remove v-prefix from release title to match the clean tag
+            NEW_NAME="${CURRENT_NAME#v}"
+            echo "Updating release title from '$CURRENT_NAME' to '$NEW_NAME'"
+
+            gh release edit "$RELEASE_TAG" --title "$NEW_NAME" --repo ${{ github.repository }}
+            echo "✅ Release title updated successfully"
           else
-            echo "Release title '$CURRENT_TITLE' does not need updating"
+            echo "ℹ️ No v-prefix found in release title or tag already has v-prefix - no changes needed"
           fi

.release-please-config.json

@@ -4,7 +4,8 @@
       "release-type": "terraform-module",
       "changelog-path": "CHANGELOG.md",
       "include-v-in-tag": false,
-      "tag-separator": ""
+      "include-component-in-tag": false
     }
-  }
+  },
+  "pull-request-title-pattern": "chore: release ${version}"
 }