Skip to content

fix(ci): simplify workflow to format and validate only#152

Merged
lgallard merged 4 commits intomasterfrom
fix-simplify-ci-workflow
Jan 1, 2026
Merged

fix(ci): simplify workflow to format and validate only#152
lgallard merged 4 commits intomasterfrom
fix-simplify-ci-workflow

Conversation

@lgallard
Copy link
Copy Markdown
Owner

@lgallard lgallard commented Jan 1, 2026

Summary

  • Remove security scan, lint, and example validation jobs
  • Keep only terraform fmt -check and terraform validate on root module
  • Eliminates CI failures from examples referencing demo files (like certificate.pem)

Problem

Renovate PRs were failing because:

  1. examples/complete/main.tf uses file("${path.module}/certificate.pem")
  2. The file doesn't exist (it's a demo placeholder)
  3. TFLint and example validation fail trying to evaluate the file() function

Solution

Simplify CI to only validate the root module:

  • terraform fmt -check -recursive - ensures code formatting
  • terraform validate - validates root module syntax
  • ❌ Example validation - removed (examples are docs, not critical)
  • ❌ TFLint - removed (causes false failures on examples)
  • ❌ tfsec - removed (already had soft_fail: true)

Test plan

  • Workflow only has one job: Validate
  • CI passes on this PR
  • Renovate PRs should pass after merge

Remove security scan, lint, and example validation jobs.
Keep only terraform fmt check and validate on root module.

This eliminates CI failures caused by examples referencing demo files
(like certificate.pem) that don't exist in the repository.

Fixes Renovate PR failures.
- Pin Terraform version to 1.11.0 in both test.yml and pre-commit.yml
- Skip detect-aws-credentials hook in CI (false positives)
- Add missing final newlines to data.tf and examples/complete/main.tf
@lgallard lgallard merged commit 702fc3a into master Jan 1, 2026
4 checks passed
@lgallard lgallard deleted the fix-simplify-ci-workflow branch January 1, 2026 21:16
@github-actions github-actions Bot mentioned this pull request Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant