Merge pull request #1907 from link-assistant/issue-1901-c51faa4821dd

Fix Playwright MCP availability and solve preflight

Author: konard

.changeset/bright-mcp-pending.md

@@ -0,0 +1,5 @@
+---
+"@link-assistant/hive-mind": patch
+---
+
+Fix Playwright MCP availability detection so pending or unavailable server status no longer enables browser automation hints, surface pending status in interactive session comments, and harden Docker verification so Playwright MCP/CLI availability is checked instead of only grepping for a registration.

Dockerfile

@@ -132,6 +132,10 @@ RUN echo "Installing @link-assistant/hive-mind@${HIVE_MIND_VERSION}" && \
 # --force handles the shared 'playwright' binary conflict between packages.
 RUN npm install -g @playwright/mcp@latest --no-fund --force
 
+# Verify both the Playwright CLI fallback and the locally installed MCP package.
+RUN playwright --version && \
+    npx --no-install @playwright/mcp --help | grep -q -- '--headless'
+
 # Configure Playwright MCP for Claude CLI — fail the build if registration fails (issue #1514)
 RUN if command -v claude &>/dev/null; then \
       claude mcp add playwright -s user -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080; \
@@ -142,6 +146,20 @@ RUN if command -v codex &>/dev/null; then \
       codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080; \
     fi
 
+# Fail the image build if MCP registration is merely present but unavailable.
+RUN if command -v claude >/dev/null 2>&1; then \
+      CLAUDE_MCP_OUTPUT="$(claude mcp list 2>&1)" && \
+      echo "$CLAUDE_MCP_OUTPUT" && \
+      echo "$CLAUDE_MCP_OUTPUT" | grep -Eiq 'playwright.*(connected|enabled)' && \
+      ! echo "$CLAUDE_MCP_OUTPUT" | grep -Eiq 'playwright.*(pending|disabled|failed|error|disconnected|not[-_[:space:]]+connected|unavailable|timed[-_[:space:]]+out|(^|[^[:alnum:]_-])timeout($|[^[:alnum:]_-]))'; \
+    fi && \
+    if command -v codex >/dev/null 2>&1; then \
+      CODEX_MCP_OUTPUT="$(codex mcp list 2>&1)" && \
+      echo "$CODEX_MCP_OUTPUT" && \
+      echo "$CODEX_MCP_OUTPUT" | grep -Eiq 'playwright.*(connected|enabled)' && \
+      ! echo "$CODEX_MCP_OUTPUT" | grep -Eiq 'playwright.*(pending|disabled|failed|error|disconnected|not[-_[:space:]]+connected|unavailable|timed[-_[:space:]]+out|(^|[^[:alnum:]_-])timeout($|[^[:alnum:]_-]))'; \
+    fi
+
 # --- Disable noisy/unused Claude Code features and tools (issue #1627, issue #1642) ---
 # Autonomous headless hive-mind runs never benefit from tools that wait for
 # human interaction (AskUserQuestion, EnterPlanMode) or that register local

Dockerfile.dind

@@ -101,6 +101,9 @@ RUN echo "Installing @link-assistant/hive-mind@${HIVE_MIND_VERSION}" && \
 
 RUN npm install -g @playwright/mcp@latest --no-fund --force
 
+RUN playwright --version && \
+    npx --no-install @playwright/mcp --help | grep -q -- '--headless'
+
 RUN if command -v claude &>/dev/null; then \
       claude mcp add playwright -s user -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080; \
     fi
@@ -109,6 +112,19 @@ RUN if command -v codex &>/dev/null; then \
       codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080; \
     fi
 
+RUN if command -v claude >/dev/null 2>&1; then \
+      CLAUDE_MCP_OUTPUT="$(claude mcp list 2>&1)" && \
+      echo "$CLAUDE_MCP_OUTPUT" && \
+      echo "$CLAUDE_MCP_OUTPUT" | grep -Eiq 'playwright.*(connected|enabled)' && \
+      ! echo "$CLAUDE_MCP_OUTPUT" | grep -Eiq 'playwright.*(pending|disabled|failed|error|disconnected|not[-_[:space:]]+connected|unavailable|timed[-_[:space:]]+out|(^|[^[:alnum:]_-])timeout($|[^[:alnum:]_-]))'; \
+    fi && \
+    if command -v codex >/dev/null 2>&1; then \
+      CODEX_MCP_OUTPUT="$(codex mcp list 2>&1)" && \
+      echo "$CODEX_MCP_OUTPUT" && \
+      echo "$CODEX_MCP_OUTPUT" | grep -Eiq 'playwright.*(connected|enabled)' && \
+      ! echo "$CODEX_MCP_OUTPUT" | grep -Eiq 'playwright.*(pending|disabled|failed|error|disconnected|not[-_[:space:]]+connected|unavailable|timed[-_[:space:]]+out|(^|[^[:alnum:]_-])timeout($|[^[:alnum:]_-]))'; \
+    fi
+
 RUN mkdir -p /home/box/.claude && \
     if [ "${HIVE_MIND_VERSION}" != "latest" ]; then \
       configure-claude --settings-path /home/box/.claude/settings.json && \

coolify/Dockerfile

@@ -127,6 +127,10 @@ RUN echo "Installing @link-assistant/hive-mind@${HIVE_MIND_VERSION}" && \
 # --force handles the shared 'playwright' binary conflict between packages.
 RUN npm install -g @playwright/mcp@latest --no-fund --force
 
+# Verify both the Playwright CLI fallback and the locally installed MCP package.
+RUN playwright --version && \
+    npx --no-install @playwright/mcp --help | grep -q -- '--headless'
+
 # Configure Playwright MCP for Claude CLI — fail the build if registration fails (issue #1514)
 RUN if command -v claude &>/dev/null; then \
       claude mcp add playwright -s user -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080; \
@@ -137,6 +141,20 @@ RUN if command -v codex &>/dev/null; then \
       codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080; \
     fi
 
+# Fail the image build if MCP registration is merely present but unavailable.
+RUN if command -v claude >/dev/null 2>&1; then \
+      CLAUDE_MCP_OUTPUT="$(claude mcp list 2>&1)" && \
+      echo "$CLAUDE_MCP_OUTPUT" && \
+      echo "$CLAUDE_MCP_OUTPUT" | grep -Eiq 'playwright.*(connected|enabled)' && \
+      ! echo "$CLAUDE_MCP_OUTPUT" | grep -Eiq 'playwright.*(pending|disabled|failed|error|disconnected|not[-_[:space:]]+connected|unavailable|timed[-_[:space:]]+out|(^|[^[:alnum:]_-])timeout($|[^[:alnum:]_-]))'; \
+    fi && \
+    if command -v codex >/dev/null 2>&1; then \
+      CODEX_MCP_OUTPUT="$(codex mcp list 2>&1)" && \
+      echo "$CODEX_MCP_OUTPUT" && \
+      echo "$CODEX_MCP_OUTPUT" | grep -Eiq 'playwright.*(connected|enabled)' && \
+      ! echo "$CODEX_MCP_OUTPUT" | grep -Eiq 'playwright.*(pending|disabled|failed|error|disconnected|not[-_[:space:]]+connected|unavailable|timed[-_[:space:]]+out|(^|[^[:alnum:]_-])timeout($|[^[:alnum:]_-]))'; \
+    fi
+
 # --- Disable noisy/unused Claude Code features and tools (issue #1627, issue #1642) ---
 # Autonomous headless hive-mind runs never benefit from tools that wait for
 # human interaction or leave persistent side effects. Pre-seed the

docs/DOCKER.hi.md

@@ -115,6 +115,43 @@ claude
 - ✅ प्रत्येक container की अपनी अलग-थलग authentication है
 - ✅ Interactive authentication के बिना सफल Docker builds
 
+## Docker में Playwright MCP State
+
+Image build अब Claude और Codex दोनों के लिए Playwright MCP register करता है:
+
+- `claude mcp add playwright -s user -- ...`
+- `codex mcp add playwright -- ...`
+
+CI workflow Docker image भी build करता है और verify करता है कि:
+
+- `playwright --version` CLI fallback के रूप में काम करता है;
+- `npx --no-install @playwright/mcp --help` MCP package को reinstall किए बिना काम करता है;
+- `claude mcp list` Playwright server को connected/enabled दिखाता है, pending या unavailable नहीं;
+- `codex mcp list` Playwright server को connected/enabled दिखाता है, pending या unavailable नहीं।
+
+यदि running container में `codex mcp list` अभी भी `No MCP servers configured yet` दिखाता है, तो सबसे संभावित root cause host से mounted `/home/box/.codex` directory है। इस image में `HOME=/home/box` है, इसलिए `/home/box/.codex` mount करने से image-baked Codex config replace हो जाता है, जिसमें preconfigured MCP entries भी शामिल हैं।
+
+इसका अर्थ है:
+
+- published image सही हो सकती है;
+- runtime container फिर भी Codex को unconfigured दिखा सकता है;
+- अंतर persisted host state के container defaults को override करने से आता है।
+
+इसे जल्दी confirm करने के लिए इन दो cases की तुलना करें:
+
+```bash
+# Host-mounted Codex state के बिना fresh container
+docker run --rm -it konard/hive-mind:latest bash -lc 'codex mcp list'
+
+# Host से persisted Codex state के साथ container
+docker run --rm -it \
+  -v /root/.hive-mind/codex:/home/box/.codex \
+  konard/hive-mind:latest \
+  bash -lc 'codex mcp list'
+```
+
+यदि पहला command `playwright` दिखाता है और दूसरा नहीं, तो host-mounted Codex directory mismatch का source है।
+
 ## पूर्वापेक्षाएं
 
 1. **Docker:** Docker Desktop या Docker Engine (version 20.10 या उच्चतर) install करें
@@ -148,6 +185,14 @@ docker volume create box-home
 docker run -it -v box-home:/home/box konard/hive-mind:latest
 ```
 
+यदि persisted `/home/box/.codex/config.toml` किसी पुराने image से आया है, तो उसमें newer images द्वारा जोड़ी गई Playwright MCP registration नहीं हो सकती। Container start होने के बाद फिर से चलाएं:
+
+```bash
+codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080
+```
+
+जब `codex mcp list` में Playwright row नहीं होती और `@playwright/mcp` installed होता है, तब Hive Mind runtime पर भी यह default registration repair try करता है। यह existing pending, disabled, या customized Playwright row को overwrite नहीं करता; उन states के लिए MCP startup path को सीधे debug करना होगा।
+
 ### Detached Mode में चलाना
 
 ```bash

docs/DOCKER.md

@@ -174,7 +174,12 @@ The image build now registers Playwright MCP for both Claude and Codex:
 - `claude mcp add playwright -s user -- ...`
 - `codex mcp add playwright -- ...`
 
-The CI workflow also builds the Docker image and verifies that both `claude mcp list` and `codex mcp list` contain `playwright`.
+The CI workflow also builds the Docker image and verifies that:
+
+- `playwright --version` works as a CLI fallback;
+- `npx --no-install @playwright/mcp --help` works without reinstalling the MCP package;
+- `claude mcp list` reports the Playwright server as connected/enabled, not pending or unavailable;
+- `codex mcp list` reports the Playwright server as connected/enabled, not pending or unavailable.
 
 If you still reproduce `codex mcp list` showing `No MCP servers configured yet` in a running container, the most likely root cause is a mounted `/home/box/.codex` directory from the host. In this image `HOME=/home/box`, so mounting `/home/box/.codex` replaces the image-baked Codex config, including any preconfigured MCP entries.
 
@@ -255,6 +260,11 @@ Because this mount fully overrides the image's `/home/box/.codex` directory, it
 codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080
 ```
 
+Hive Mind also attempts this default registration repair at runtime when
+`codex mcp list` has no Playwright row and `@playwright/mcp` is installed. It
+does not overwrite an existing Playwright row that is pending, disabled, or
+customized; those states need direct MCP startup debugging.
+
 ### Running in Detached Mode
 
 ```bash

docs/DOCKER.ru.md

@@ -115,6 +115,43 @@ claude
 - ✅ Каждый контейнер имеет собственную изолированную аутентификацию
 - ✅ Успешные сборки Docker без интерактивной аутентификации
 
+## Состояние Playwright MCP в Docker
+
+Сборка образа теперь регистрирует Playwright MCP и для Claude, и для Codex:
+
+- `claude mcp add playwright -s user -- ...`
+- `codex mcp add playwright -- ...`
+
+CI workflow также собирает Docker-образ и проверяет, что:
+
+- `playwright --version` работает как CLI fallback;
+- `npx --no-install @playwright/mcp --help` работает без повторной установки MCP package;
+- `claude mcp list` сообщает Playwright server как connected/enabled, а не pending или unavailable;
+- `codex mcp list` сообщает Playwright server как connected/enabled, а не pending или unavailable.
+
+Если в запущенном контейнере `codex mcp list` всё ещё показывает `No MCP servers configured yet`, наиболее вероятная причина — смонтированная с хоста директория `/home/box/.codex`. В этом образе `HOME=/home/box`, поэтому mount `/home/box/.codex` заменяет встроенную в образ Codex config, включая заранее настроенные MCP entries.
+
+Это означает:
+
+- опубликованный образ может быть корректным;
+- runtime container всё равно может показывать Codex как unconfigured;
+- отличие вызвано persisted host state, который переопределяет defaults контейнера.
+
+Чтобы быстро проверить это, сравните два случая:
+
+```bash
+# Fresh container without host-mounted Codex state
+docker run --rm -it konard/hive-mind:latest bash -lc 'codex mcp list'
+
+# Container with persisted Codex state from host
+docker run --rm -it \
+  -v /root/.hive-mind/codex:/home/box/.codex \
+  konard/hive-mind:latest \
+  bash -lc 'codex mcp list'
+```
+
+Если первая команда показывает `playwright`, а вторая нет, источник расхождения — смонтированная с хоста директория Codex.
+
 ## Предварительные требования
 
 1. **Docker:** Установите Docker Desktop или Docker Engine (версия 20.10 или выше)
@@ -148,6 +185,14 @@ docker volume create box-home
 docker run -it -v box-home:/home/box konard/hive-mind:latest
 ```
 
+Если persisted `/home/box/.codex/config.toml` пришёл из старого образа, в нём может не быть Playwright MCP registration, добавленной в новых образах. После запуска контейнера выполните заново:
+
+```bash
+codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080
+```
+
+Hive Mind также пытается выполнить этот default registration repair во время runtime, когда `codex mcp list` не содержит Playwright row и `@playwright/mcp` установлен. Он не перезаписывает существующую Playwright row в состоянии pending, disabled или с custom settings; такие состояния требуют прямой отладки MCP startup path.
+
 ### Запуск в фоновом режиме
 
 ```bash

docs/DOCKER.zh.md

@@ -115,6 +115,43 @@ claude
 - ✅ 每个容器拥有独立的身份验证
 - ✅ 无需交互式身份验证即可成功构建 Docker 镜像
 
+## Docker 中的 Playwright MCP 状态
+
+镜像构建现在会为 Claude 和 Codex 注册 Playwright MCP：
+
+- `claude mcp add playwright -s user -- ...`
+- `codex mcp add playwright -- ...`
+
+CI 工作流还会构建 Docker 镜像并验证：
+
+- `playwright --version` 可作为 CLI fallback 使用；
+- `npx --no-install @playwright/mcp --help` 可在不重新安装 MCP 包的情况下运行；
+- `claude mcp list` 将 Playwright server 报告为 connected/enabled，而不是 pending 或 unavailable；
+- `codex mcp list` 将 Playwright server 报告为 connected/enabled，而不是 pending 或 unavailable。
+
+如果运行中的容器里 `codex mcp list` 仍显示 `No MCP servers configured yet`，最可能的原因是从宿主机挂载了 `/home/box/.codex`。在此镜像中 `HOME=/home/box`，因此挂载 `/home/box/.codex` 会替换镜像内置的 Codex 配置，包括预配置的 MCP 条目。
+
+这意味着：
+
+- 发布的镜像可能是正确的；
+- 运行时容器仍可能显示 Codex 未配置；
+- 差异来自持久化宿主机状态覆盖了容器默认值。
+
+快速确认方式是比较以下两种情况：
+
+```bash
+# 不挂载宿主机 Codex 状态的新容器
+docker run --rm -it konard/hive-mind:latest bash -lc 'codex mcp list'
+
+# 挂载宿主机持久化 Codex 状态的容器
+docker run --rm -it \
+  -v /root/.hive-mind/codex:/home/box/.codex \
+  konard/hive-mind:latest \
+  bash -lc 'codex mcp list'
+```
+
+如果第一条命令显示 `playwright` 而第二条没有，则宿主机挂载的 Codex 目录就是差异来源。
+
 ## 前提条件
 
 1. **Docker**：安装 Docker Desktop 或 Docker Engine（版本 20.10 或更高）
@@ -148,6 +185,14 @@ docker volume create box-home
 docker run -it -v box-home:/home/box konard/hive-mind:latest
 ```
 
+如果持久化的 `/home/box/.codex/config.toml` 来自较旧镜像，可能缺少新版镜像添加的 Playwright MCP 注册。容器启动后可重新运行：
+
+```bash
+codex mcp add playwright -- npx -y @playwright/mcp@latest --isolated --headless --no-sandbox --timeout-action=600000 --viewport-size 1920x1080
+```
+
+当 `codex mcp list` 没有 Playwright 行且已安装 `@playwright/mcp` 时，Hive Mind 也会在运行时尝试这种默认注册修复。它不会覆盖已有的 pending、disabled 或自定义 Playwright 行；这些状态需要直接调试 MCP 启动路径。
+
 ### 以守护进程模式运行
 
 ```bash