Updating to newest release

Author: LinkDotNet Bot

CHANGELOG.md

@@ -6,6 +6,12 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 
 ## [Unreleased]
 
+## [3.4.1] - 2026-02-19
+
+### Fixed
+
+- Use correct culture (`CurrentCulture`) when no `FormatProvider` is provided in `Append` and `Insert` methods.
+
 ## [3.4.0] - 2026-02-18
 
 ### Added
@@ -533,7 +539,8 @@ This release brings extensions to the `ValueStringBuilder` API. For `v1.0` the `
 
 - Initial release
 
-[unreleased]: https://github.com/linkdotnet/StringBuilder/compare/3.4.0...HEAD
+[unreleased]: https://github.com/linkdotnet/StringBuilder/compare/3.4.1...HEAD
+[3.4.1]: https://github.com/linkdotnet/StringBuilder/compare/3.4.0...3.4.1
 [3.4.0]: https://github.com/linkdotnet/StringBuilder/compare/3.3.0...3.4.0
 [3.3.0]: https://github.com/linkdotnet/StringBuilder/compare/3.2.0...3.3.0
 [3.2.0]: https://github.com/linkdotnet/StringBuilder/compare/3.1.0...3.2.0

src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs

@@ -1,4 +1,3 @@
-using System.Globalization;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Text;
@@ -53,7 +52,7 @@ public unsafe void Append(bool value)
     /// <param name="format">Optional formatter. If not provided the default of the given instance is taken.</param>
     /// <param name="bufferSize">Size of the buffer allocated. If you have a custom type that implements <see cref="ISpanFormattable"/> that
     /// requires more space than the default (36 characters), adjust the value.</param>
-    /// <param name="formatProvider">Optional format provider. If null <see cref="CultureInfo.InvariantCulture"/> is used.</param>
+    /// <param name="formatProvider">Optional format provider.</param>
     /// <typeparam name="T">Any <see cref="ISpanFormattable"/>.</typeparam>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public void Append<T>(T value, scoped ReadOnlySpan<char> format = default, int bufferSize = 36, IFormatProvider? formatProvider = null)
@@ -192,7 +191,7 @@ private void AppendSpanFormattable<T>(T value, scoped ReadOnlySpan<char> format
             EnsureCapacity(newSize);
         }
 
-        if (!value.TryFormat(buffer[bufferPosition..], out var written, format, formatProvider ?? CultureInfo.InvariantCulture))
+        if (!value.TryFormat(buffer[bufferPosition..], out var written, format, formatProvider))
         {
             throw new InvalidOperationException($"Could not insert {value} into given buffer. Is the buffer (size: {bufferSize}) large enough?");
         }

src/LinkDotNet.StringBuilder/ValueStringBuilder.Insert.cs

@@ -1,4 +1,3 @@
-using System.Globalization;
 using System.Runtime.CompilerServices;
 using System.Text;
 
@@ -44,7 +43,7 @@ public void Insert(int index, Rune value)
     /// <param name="value">Formattable span to insert into this builder.</param>
     /// <param name="format">Optional formatter. If not provided the default of the given instance is taken.</param>
     /// <param name="bufferSize">Size of the buffer allocated on the stack.</param>
-    /// <param name="formatProvider">Optional format provider. If null <see cref="CultureInfo.InvariantCulture"/> is used.</param>
+    /// <param name="formatProvider">Optional format provider.</param>
     /// <typeparam name="T">Any <see cref="ISpanFormattable"/>.</typeparam>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public void Insert<T>(int index, T value, scoped ReadOnlySpan<char> format = default, int bufferSize = 36, IFormatProvider? formatProvider = null)
@@ -105,7 +104,7 @@ private void InsertSpanFormattable<T>(int index, T value, scoped ReadOnlySpan<ch
         }
 
         Span<char> tempBuffer = stackalloc char[bufferSize];
-        if (value.TryFormat(tempBuffer, out var written, format, formatProvider ?? CultureInfo.InvariantCulture))
+        if (value.TryFormat(tempBuffer, out var written, format, formatProvider))
         {
             var newLength = bufferPosition + written;
             if (newLength > buffer.Length)

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Append.Tests.cs

@@ -100,21 +100,15 @@ public void ShouldAppendSpanFormattableWithGivenCulture()
     }
 
     [Fact]
-    public void ShouldAppendSpanFormattableWithInvariantCultureWhenFormatProviderIsNull()
+    public void ShouldAppendSpanFormattableWithCurrentCultureWhenFormatProviderIsNull()
     {
+        CultureInfo.CurrentCulture = CultureInfo.GetCultureInfo("de-DE");
         using var builder = new ValueStringBuilder();
         var originalCulture = CultureInfo.CurrentCulture;
-        try
-        {
-            CultureInfo.CurrentCulture = CultureInfo.GetCultureInfo("de-DE");
-            builder.Append(1.2m, formatProvider: null);
-        }
-        finally
-        {
-            CultureInfo.CurrentCulture = originalCulture;
-        }
+        builder.Append(1.2m, formatProvider: null);
 
-        builder.ToString().ShouldBe("1.2");
+        CultureInfo.CurrentCulture = originalCulture;
+        builder.ToString().ShouldBe("1,2");
     }
 
     [Fact]

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Insert.Tests.cs

@@ -48,19 +48,14 @@ public void ShouldInsertSpanFormattableWithGivenCulture()
     [Fact]
     public void ShouldInsertSpanFormattableWithInvariantCultureWhenFormatProviderIsNull()
     {
+        CultureInfo.CurrentCulture = CultureInfo.GetCultureInfo("de-DE");
         using var builder = new ValueStringBuilder();
         var originalCulture = CultureInfo.CurrentCulture;
-        try
-        {
-            CultureInfo.CurrentCulture = CultureInfo.GetCultureInfo("de-DE");
-            builder.Insert(0, 1.2m, formatProvider: null);
-        }
-        finally
-        {
-            CultureInfo.CurrentCulture = originalCulture;
-        }
 
-        builder.ToString().ShouldBe("1.2");
+        builder.Insert(0, 1.2m, formatProvider: null);
+
+        CultureInfo.CurrentCulture = originalCulture;
+        builder.ToString().ShouldBe("1,2");
     }
 
     [Fact]