The query string is built incorrectly when the path contains a parameter

[simoncas]

Describe the bug
The URL is crafted incorrectly when the path already contains a query string and when additional parameters are added through the options.
Example: https://reqres.in/api/users?param1=value1?param2=value2

To Reproduce
Steps to reproduce the behavior:
url: http://whatever.com
path: /whatever?param1=value1
parameters: param2 as Key1 and value2 as Value1
Open the developer tools and select the network tab. Filter requests by XHR
Send the request by hitting the Send button.
Using the developer tools, analyze the HTTP request crafted by postwoman, especially the URL

The URL is https://reqres.in/api/users?param1=value1?param2=value2 which isn't valid. The query string isn't valid since the parameters are preceded twice by a question mark. The second parameter should be preceded by a "&" instead.

Expected behavior
The crafted URL should be https://reqres.in/api/users?param1=value1&param2=value2.
In other words, if the path already contains a query string then the additional parameters specified through the parameter section must be correctly added.

Screenshots

[liyasthomas]

While we're finding a fix to this issue, I suggest you to separate parameters from request path and use Parameters section to specify required parameters.

[simoncas]

I'm okay to work on this.

They are 2 ways to solve this issue.

First option:
Check with a regex if the query string already contains parameters. Then based on the result, craft correctly the query string. (quick fix)

Second option:
Extract the parameters from the path and automatically fill the parameters sections with the params. (postman style). We must also decide if we should keep in sync (bidirectional) the parameters section and the path. This is how it's implemented by postman. When a change is made whether to the path or to the parameters sections then the change is replicated to the other component.
(sounds more like a feature).

What do you think ?

[liyasthomas]

Second option sounds great! I've assigned this to you. Looking forward on your PR 🙌

[liyasthomas]

#62 can also be solved with the second approach of binding key-value pairs to a fast URL entry input box. @NBTX

[AndrewBastin]

Yoo, I was kinda working on a PR myself for this... My idea to resolve this was on clicking the Send button, the path input is parsed and the values are appended to the params list.

[AndrewBastin]

Hi there,

So, I am kinda busy as I am moving to Canada and won't be back on proper coding till like the end of the week, so in the meantime, I am unassigning myself from this issue, anyone interested to tackle this issue please feel to do so.