Re-order sections and add toggle for including authentication in URL#215
Merged
NBTX merged 1 commit intohoppscotch:masterfrom Oct 25, 2019
SamJakob:master
Merged
Re-order sections and add toggle for including authentication in URL#215NBTX merged 1 commit intohoppscotch:masterfrom SamJakob:master
NBTX merged 1 commit intohoppscotch:masterfrom
SamJakob:master
Conversation
DeepCode Report (#0673cf)DeepCode analyzed this pull request. |
|
Hey @NBTX, TravisBuddy Request Identifier: 5e6d4640-f743-11e9-bdcb-879e987f4e2b |
Member
|
I think having request and response sections next to each other is better. Did you find difficulties to scroll down for request options..? I don't know. Maybe maintaining the flow as in this PR is better. 👍 |
Contributor
Author
|
@liyasthomas I thought it made more logical sense to have request options to the request section - and then they're more intuitively obvious as request options. |
Member
|
Proceed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-orders the sections as follows:
Additionally, this adds a toggle to the Authentication section (the value of which is saved) that allows a user to toggle whether or not they want the authentication information in the URL.
Authentication in the URL is also now turned off by default for security reasons.
Closes #178