Skip to content

Basic i18n support#351

Merged
liyasthomas merged 4 commits intomasterfrom
i18n
Nov 27, 2019
Merged

Basic i18n support#351
liyasthomas merged 4 commits intomasterfrom
i18n

Conversation

@liyasthomas
Copy link
Copy Markdown
Member

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Nov 27, 2019

DeepCode Report (#a74522)

DeepCode analyzed this pull request.
There are no new issues.

@liyasthomas liyasthomas mentioned this pull request Nov 27, 2019
@TravisBuddy
Copy link
Copy Markdown

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b384afe0-10f9-11ea-b8ff-d5ab8a371226

@TravisBuddy
Copy link
Copy Markdown

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 655fdba0-10fe-11ea-b8ff-d5ab8a371226

@liyasthomas
Copy link
Copy Markdown
Member Author

Retry DeepCode

@TravisBuddy
Copy link
Copy Markdown

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 87f69310-10ff-11ea-b8ff-d5ab8a371226

@liyasthomas liyasthomas self-assigned this Nov 27, 2019
@liyasthomas liyasthomas requested a review from NBTX November 27, 2019 10:30
@liyasthomas
Copy link
Copy Markdown
Member Author

@NBTX please review this.

@liyasthomas liyasthomas added core Changes regarding core concepts feature New feature or request labels Nov 27, 2019
@liyasthomas liyasthomas added this to the v2.0 milestone Nov 27, 2019
@TravisBuddy
Copy link
Copy Markdown

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: db1f0900-110e-11ea-b8ff-d5ab8a371226

@liyasthomas liyasthomas merged commit 623b177 into master Nov 27, 2019
@liyasthomas liyasthomas deleted the i18n branch November 27, 2019 12:10
@liyasthomas liyasthomas restored the i18n branch November 27, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes regarding core concepts feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants