Skip to content

Adapt extension check to new extensions#583

Merged
AndrewBastin merged 1 commit intohoppscotch:masterfrom
levrik:extension-check
Feb 21, 2020
Merged

Adapt extension check to new extensions#583
AndrewBastin merged 1 commit intohoppscotch:masterfrom
levrik:extension-check

Conversation

@levrik
Copy link
Copy Markdown
Contributor

@levrik levrik commented Feb 20, 2020

Follow-up to #573

@levrik levrik requested a review from liyasthomas February 20, 2020 18:36
@ghost
Copy link
Copy Markdown

ghost commented Feb 20, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.105 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@levrik levrik requested a review from AndrewBastin February 20, 2020 18:37
@TravisBuddy
Copy link
Copy Markdown

Hey @levrik,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a76235b0-5411-11ea-8c1a-9b7181e82441

Copy link
Copy Markdown
Contributor

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewBastin AndrewBastin merged commit 9b9fb62 into hoppscotch:master Feb 21, 2020
@TravisBuddy
Copy link
Copy Markdown

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 5f5a7e10-5459-11ea-85e8-55831522a411

@levrik levrik deleted the extension-check branch February 21, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants