Skip to content

Environment Mangement#591

Merged
liyasthomas merged 8 commits intomasterfrom
feature/env-manager
Feb 24, 2020
Merged

Environment Mangement#591
liyasthomas merged 8 commits intomasterfrom
feature/env-manager

Conversation

@JacobAnavisca
Copy link
Copy Markdown
Contributor

@JacobAnavisca JacobAnavisca commented Feb 23, 2020 •
edited by liyasthomas
Loading

  • Add Environment

  • Edit Environment

  • Delete Environment

  • Sync Environments

  • Review

@ghost
Copy link
Copy Markdown

ghost commented Feb 23, 2020 •
edited by ghost
Loading

DeepCode's analysis on #4f7f2b found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@JacobAnavisca JacobAnavisca mentioned this pull request Feb 23, 2020
Closed
liyasthomas
liyasthomas reviewed Feb 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean & neat implementation

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 23, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 080e9770-565e-11ea-8ad8-19cca21d7143

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 23, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: cc919c60-5662-11ea-8ad8-19cca21d7143

@liyasthomas liyasthomas added core Changes regarding core concepts feature New feature or request labels Feb 23, 2020
@liyasthomas liyasthomas added this to the v2.0 milestone Feb 23, 2020
@liyasthomas liyasthomas self-assigned this Feb 23, 2020
NBTX
NBTX suggested changes Feb 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NBTX NBTX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I've just got a few suggestions to polish it up.

@NBTX NBTX changed the title Env management Environment Mangement Feb 23, 2020
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 23, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bfb031f0-5671-11ea-8ad8-19cca21d7143

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 23, 2020

Hey @JacobAnavisca,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: fe3b96c0-5672-11ea-8ad8-19cca21d7143

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 24, 2020

Hey @JacobAnavisca,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 51d4dba0-569d-11ea-8ad8-19cca21d7143

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 24, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9bb3ae80-56a8-11ea-8ad8-19cca21d7143

@JacobAnavisca JacobAnavisca requested a review from NBTX February 24, 2020 03:34
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 24, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: ab84ea40-56b7-11ea-8ad8-19cca21d7143

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 24, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bcdb6440-56b7-11ea-8ad8-19cca21d7143

AndrewBastin
AndrewBastin approved these changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Feb 24, 2020

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bb177b10-56e1-11ea-8ad8-19cca21d7143

@liyasthomas liyasthomas merged commit f05a875 into master Feb 24, 2020
@liyasthomas liyasthomas linked an issue Feb 25, 2020 that may be closed by this pull request
Fast URL entry #62
Closed
@liyasthomas liyasthomas mentioned this pull request Feb 25, 2020
Closed
@liyasthomas liyasthomas removed a link to an issue Feb 25, 2020
Fast URL entry #62
Closed
@liyasthomas liyasthomas linked an issue Feb 25, 2020 that may be closed by this pull request
Import and export environments from JSON #190
Closed
@liyasthomas liyasthomas mentioned this pull request Feb 25, 2020
Closed
@liyasthomas liyasthomas deleted the feature/env-manager branch February 27, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

+2 more reviewers

@NBTX NBTX NBTX requested changes

@AndrewBastin AndrewBastin AndrewBastin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liyasthomas liyasthomas

@JacobAnavisca JacobAnavisca

Labels

core Changes regarding core concepts feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import and export environments from JSON

5 participants

@JacobAnavisca @TravisBuddy @AndrewBastin @liyasthomas @NBTX
⚡