Switched to update

For some reason, if we try to run .save() after removing the last domain in a users list, the empty array is not saved and the last domain is not deleted. Domains can be deleted if there are more than one, however the very last domain could not.

A similar issue was seen when adding an alias, hence that has also been changed to .update()

The return types of the two methods have been changed, however they are only used in one place each and the return values are not used so there is no issue here.

Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>

Author: Computroniks

src/users/users.service.ts

@@ -18,7 +18,7 @@ import { Package } from 'src/packages/package.entity'
 import { PackagesService } from 'src/packages/packages.service'
 import { DeleteForDomainData } from 'src/tasks/delete-for-domain/delete-for-domain.interfaces'
 import { SuspensionData } from 'src/tasks/suspension/suspension.interfaces'
-import { MongoRepository } from 'typeorm'
+import { MongoRepository, UpdateResult } from 'typeorm'
 
 import { CreateUserDto } from './dto/create-user.dto'
 import { UpdateUserDto } from './dto/update-user.dto'
@@ -137,7 +137,7 @@ export class UsersService {
     }
   }
 
-  public async pullDomain(userId: string, domain: string): Promise<User> {
+  public async pullDomain(userId: string, domain: string): Promise<UpdateResult> {
     const user = await this.findByIdNoPassword(userId)
     const userEntity = new User()
     Object.assign(userEntity, user)
@@ -146,7 +146,7 @@ export class UsersService {
     userEntity.domains = userEntity.domains.filter((domainObject) => domainObject.domain !== domain)
 
     try {
-      return this.userRepository.save(userEntity)
+      return this.userRepository.update({ _id: userEntity._id }, { domains: userEntity.domains })
     } catch (error) {
       // TODO: add custom exception handler for unknown errors that basically does the following:
       const errorId = NanoId()
@@ -155,7 +155,7 @@ export class UsersService {
     }
   }
 
-  public async pushAlias(userId: string, domain: string, alias: DomainAlias): Promise<User | undefined> {
+  public async pushAlias(userId: string, domain: string, alias: DomainAlias): Promise<UpdateResult | undefined> {
     const user = await this.findByIdNoPassword(userId)
     const userEntity = new User()
     Object.assign(userEntity, user)
@@ -171,7 +171,7 @@ export class UsersService {
     })
 
     try {
-      return await this.userRepository.save(userEntity)
+      return await this.userRepository.update({ _id: userEntity._id }, { domains: userEntity.domains })
     } catch (error) {
       const errorId = NanoId()
       this.logger.error(`${errorId}: ${error.message}`)