Run analysis on CI

Author: JohnnyMorganz

.github/workflows/ci.yml

@@ -59,3 +59,6 @@ jobs:
     - name: Build
       # Build your program with the given configuration. Note that --config is needed because the default Windows generator is a multi-config generator (Visual Studio generator).
       run: cmake --build ${{ steps.strings.outputs.build-output-dir }} --config ${{ matrix.build_type }} --parallel
+
+    - name: Run Analysis
+      run: ${{ steps.strings.outputs.build-output-dir }}/lute --check std batteries examples

.luaurc

@@ -3,5 +3,6 @@
     "aliases": {
         "batteries": "batteries",
         "std": "std",
+        "lute": "definitions"
     }
 }

cli/tc.cpp

@@ -4,31 +4,9 @@
 #include "Luau/Error.h"
 #include "Luau/Transpiler.h"
 #include "Luau/TypeAttach.h"
+#include "Luau/Require.h"
 
-static const std::string kLuteDefinitions = R"LUTE_TYPES(
--- Net api
-declare net: {
-    get: (string) -> string,
-    getAsync: (string) -> string,
-}
--- fs api
-declare class file end
-declare fs: {
- -- probably not the correct sig
-    open: (string, "r" | "w" | "a" | "r+" | "w+") -> file,
-    close: (file) -> (),
-    read: (file) -> string,
-    write: (file, string) -> (),
-    readfiletostring : (string) -> string,
-    writestringtofile : (string, string) -> (),
- -- is this right? I feel like we want a promise type here
-    readasync : (string) -> string,
-}
-
--- globals
-declare function spawn(path: string): any
-
-)LUTE_TYPES";
+LUAU_FASTFLAG(LuauSolverV2)
 
 struct LuteFileResolver : Luau::FileResolver
 {
@@ -57,7 +35,21 @@ struct LuteFileResolver : Luau::FileResolver
 
     std::optional<Luau::ModuleInfo> resolveModule(const Luau::ModuleInfo* context, Luau::AstExpr* node) override
     {
-	// TODO: Need to handle requires
+        if (Luau::AstExprConstantString* expr = node->as<Luau::AstExprConstantString>())
+        {
+            std::string path{expr->value.data, expr->value.size};
+
+            AnalysisRequireContext requireContext{context->name};
+            AnalysisCacheManager cacheManager;
+            AnalysisErrorHandler errorHandler;
+
+            RequireResolver resolver(path, requireContext, cacheManager, errorHandler);
+            RequireResolver::ResolvedRequire resolvedRequire = resolver.resolveRequire();
+
+            if (resolvedRequire.status == RequireResolver::ModuleStatus::FileRead)
+                return {{resolvedRequire.identifier}};
+        }
+
         return std::nullopt;
     }
 
@@ -69,7 +61,46 @@ struct LuteFileResolver : Luau::FileResolver
     }
 
 private:
-// TODO: add require resolver;
+    struct AnalysisRequireContext : RequireResolver::RequireContext
+    {
+        explicit AnalysisRequireContext(std::string path)
+            : path(std::move(path))
+        {
+        }
+
+        std::string getPath() override
+        {
+            return path;
+        }
+
+        bool isRequireAllowed() override
+        {
+            return true;
+        }
+
+        bool isStdin() override
+        {
+            return path == "-";
+        }
+
+        std::string createNewIdentifer(const std::string& path) override
+        {
+            return path;
+        }
+
+    private:
+        std::string path;
+    };
+
+    struct AnalysisCacheManager : public RequireResolver::CacheManager
+    {
+        AnalysisCacheManager() = default;
+    };
+
+    struct AnalysisErrorHandler : RequireResolver::ErrorHandler
+    {
+        AnalysisErrorHandler() = default;
+    };
 };
 
 struct LuteConfigResolver : Luau::ConfigResolver
@@ -182,6 +213,9 @@ static bool reportModuleResult(Luau::Frontend& frontend, const Luau::ModuleName&
 
 int typecheck(const std::vector<std::string> sourceFiles)
 {
+    // Lute only supports the new type solver
+    FFlag::LuauSolverV2.value = true;
+
     Luau::Mode mode = Luau::Mode::Strict;
     bool annotate = true;
     std::string basePath = "";
@@ -195,9 +229,6 @@ int typecheck(const std::vector<std::string> sourceFiles)
     Luau::Frontend frontend(&fileResolver, &configResolver, frontendOptions);
 
     Luau::registerBuiltinGlobals(frontend, frontend.globals);
-    Luau::LoadDefinitionFileResult loadResult =
-        frontend.loadDefinitionFile(frontend.globals, frontend.globals.globalScope, kLuteDefinitions, "@luau", false, false);
-    LUAU_ASSERT(loadResult.success);
     Luau::freeze(frontend.globals.globalTypes);
 
     for (const std::string& path : sourceFiles)

definitions/fs.luau

@@ -0,0 +1,63 @@
+local fs = {}
+
+export type FileHandle = {
+	fd: number,
+	err: number,
+}
+
+export type FileType = "file" | "dir" | "link" | "fifo" | "socket" | "char" | "block" | "unknown"
+
+export type DirectoryEntry = {
+	name: string,
+	type: FileType,
+}
+
+function fs.open(path: string): FileHandle
+	error("not implemented")
+end
+
+function fs.read(handle: FileHandle): string
+	error("not implemented")
+end
+
+function fs.write(handle: FileHandle, contents: string): ()
+	error("not implemented")
+end
+
+function fs.close(handle: FileHandle): ()
+	error("not implemented")
+end
+
+function fs.remove(path: string): ()
+	error("not implemented")
+end
+
+function fs.type(path: string): FileType
+	error("not implemented")
+end
+
+function fs.mkdir(path: string): ()
+	error("not implemented")
+end
+
+function fs.listdir(path: string): { DirectoryEntry }
+	error("not implemented")
+end
+
+function fs.rmdir(path: string): ()
+	error("not implemented")
+end
+
+function fs.readfiletostring(filepath: string): string
+	error("not implemented")
+end
+
+function fs.writestringtofile(filepath: string, contents: string): ()
+	error("not implemented")
+end
+
+function fs.readasync(filepath: string): string
+	error("not implemented")
+end
+
+return fs

definitions/luau.luau

@@ -0,0 +1,16 @@
+local luau = {}
+
+type ParseResult = {
+	root: any,
+	lines: number,
+}
+
+function luau.parse(source: string): ParseResult
+	error("not implemented")
+end
+
+function luau.parseexpr(source: string): ParseResult
+	error("not implemented")
+end
+
+return luau

definitions/net.luau

@@ -0,0 +1,11 @@
+local net = {}
+
+function net.get(url: string): string
+	error("not implemented")
+end
+
+function net.getAsync(url: string): string
+	error("not implemented")
+end
+
+return net

definitions/task.luau

@@ -0,0 +1,5 @@
+local task = {}
+
+function task.defer() end
+
+return task

definitions/vm.luau

@@ -0,0 +1,7 @@
+local vm = {}
+
+function vm.spawn(file: string): any
+	error("not implemented")
+end
+
+return vm

vm/include/lute/vm.h

@@ -16,7 +16,7 @@ namespace vm
 int lua_defer(lua_State* L);
 
 static const luaL_Reg lib[] = {
-    {"create", lua_spawn},
+    {"spawn", lua_spawn},
     {nullptr, nullptr},
 };