CST: Improve serialization of table expressions (#250)

This PR fixes some bugs in the serialization of table expressions, and
adds some regression tests for that.

Author: JohnnyMorganz

luau/src/luau.cpp

@@ -349,12 +349,15 @@ struct AstSerialize : public Luau::AstVisitor
     void serialize(Luau::AstExprTable::Item& item, Luau::CstExprTable::Item* cstNode)
     {
         lua_rawcheckstack(L, 2);
-        lua_createtable(L, 0, 6);
+        lua_createtable(L, 0, 7);
 
         if (item.kind == Luau::AstExprTable::Item::List)
         {
             lua_pushstring(L, "list");
             lua_setfield(L, -2, "kind");
+
+            visit(item.value);
+            lua_setfield(L, -2, "value");
         }
         else if (item.kind == Luau::AstExprTable::Item::Record)
         {
@@ -376,7 +379,7 @@ struct AstSerialize : public Luau::AstVisitor
         }
         else if (item.kind == Luau::AstExprTable::Item::General)
         {
-            lua_pushstring(L, "record");
+            lua_pushstring(L, "general");
             lua_setfield(L, -2, "kind");
 
             if (cstNode && cstNode->indexerOpenPosition)
@@ -390,17 +393,17 @@ struct AstSerialize : public Luau::AstVisitor
 
             if (cstNode)
             {
-                if (cstNode->equalsPosition)
-                {
-                    serializeToken(cstNode->equalsPosition.value(), "=");
-                    lua_setfield(L, -2, "equals");
-                }
-
                 if (cstNode->indexerClosePosition)
                 {
                     serializeToken(cstNode->indexerClosePosition.value(), "]");
                     lua_setfield(L, -2, "indexerClose");
                 }
+
+                if (cstNode->equalsPosition)
+                {
+                    serializeToken(cstNode->equalsPosition.value(), "=");
+                    lua_setfield(L, -2, "equals");
+                }
             }
 
             visit(item.value);

tests/astSerializerTests/table-1.luau

@@ -0,0 +1 @@
+local x = { 1, 2, 3 }

tests/astSerializerTests/table-2.luau

@@ -0,0 +1,3 @@
+local x = {
+	["test"] = true,
+}

tests/testAstSerializer.spec.luau

@@ -147,6 +147,8 @@ local function test_roundtrippableAst()
 		"tests/astSerializerTests/interpolated-string-2.luau",
 		"tests/astSerializerTests/local-function-declaration-1.luau",
 		"tests/astSerializerTests/numeric-for-loop-1.luau",
+		"tests/astSerializerTests/table-1.luau",
+		"tests/astSerializerTests/table-2.luau",
 		"tests/astSerializerTests/type-assertion-1.luau",
 		"tests/astSerializerTests/type-singletons-1.luau",
 		"tests/astSerializerTests/while-1.luau",