Commit 296dbbb
Address CodeRabbit (df968da): use injected hostBundle + localize readiness-timeout error
- ensureSparkleInstallationCache uses the injected hostBundle.bundleIdentifier instead of
Bundle.main (consistency with the hostBundle param already used for SPUUpdater; the
Sparkle install cache is keyed by the host app's bundle id).
- The 'Updater is still starting' NSError description is now String(localized:
update.error.notReady) with en + ja in Localizable.xcstrings (was hardcoded English).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent df968da commit 296dbbb
2 files changed
Lines changed: 21 additions & 2 deletions
File tree
- Packages/CmuxUpdater/Sources/CmuxUpdater
- Resources
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| 80 | + | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
| |||
279 | 281 | | |
280 | 282 | | |
281 | 283 | | |
282 | | - | |
| 284 | + | |
283 | 285 | | |
284 | 286 | | |
285 | 287 | | |
| |||
381 | 383 | | |
382 | 384 | | |
383 | 385 | | |
384 | | - | |
| 386 | + | |
385 | 387 | | |
386 | 388 | | |
387 | 389 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134765 | 134765 | | |
134766 | 134766 | | |
134767 | 134767 | | |
| 134768 | + | |
| 134769 | + | |
| 134770 | + | |
| 134771 | + | |
| 134772 | + | |
| 134773 | + | |
| 134774 | + | |
| 134775 | + | |
| 134776 | + | |
| 134777 | + | |
| 134778 | + | |
| 134779 | + | |
| 134780 | + | |
| 134781 | + | |
| 134782 | + | |
| 134783 | + | |
| 134784 | + | |
134768 | 134785 | | |
134769 | 134786 | | |
134770 | 134787 | | |
| |||
0 commit comments